Chromium Code Reviews Chromium Code Reviews
Issue 1548283003:
Add P2 UMA metrics for Media Router user actions. (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: tools/metrics/histograms/histograms.xml |
| diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml |
| index 7811dbedc20198f909c085e4afaf6c830e6ac9d7..77c438000bec5e9b54b4689b75161ce3f5d04b19 100644 |
| --- a/tools/metrics/histograms/histograms.xml |
| +++ b/tools/metrics/histograms/histograms.xml |
| @@ -19639,6 +19639,14 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. |
| </summary> |
| </histogram> |
| +<histogram name="MediaRouter.Ui.Action.StartLocalPosition"> |
| + <owner>apacible@chromium.org</owner> |
| + <summary> |
| + The index of the sink that was selected in the sink list. Always expected to |
| + be non-negative. |
|
Ilya Sherman
2015/12/28 23:13:00
Histograms don't actually record negative samples,
apacible
2015/12/29 01:21:01
Removed comment about non-negativity.
|
| + </summary> |
| +</histogram> |
| + |
| <histogram name="MediaRouter.Ui.Action.StartLocalSessionSuccessful" |
| enum="BooleanSuccess"> |
| <owner>apacible@chromium.org</owner> |
| @@ -19647,6 +19655,11 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. |
| </summary> |
| </histogram> |
| +<histogram name="MediaRouter.Ui.Action.StopRoute" enum="MediaRouteType"> |
| + <owner>apacible@chromium.org</owner> |
| + <summary>The number of times a user stops different types of routes.</summary> |
| +</histogram> |
| + |
| <histogram name="MediaRouter.Ui.Device.Count"> |
| <owner>apacible@chromium.org</owner> |
| <summary> |
| @@ -19671,6 +19684,14 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. |
| </summary> |
| </histogram> |
| +<histogram name="MediaRouter.Ui.Navigate.SourceSelection" |
| + enum="MediaRouterSourceTypes"> |
| + <owner>apacible@chromium.org</owner> |
| + <summary> |
| + The number of times the user selects a specific cast source type. |
| + </summary> |
| +</histogram> |
| + |
| <histogram name="Memory.BackingStore"> |
| <owner>hajimehoshi@chromium.org</owner> |
| <owner>kenjibaheux@google.com</owner> |
| @@ -70363,6 +70384,17 @@ To add a new entry, add it with any value and run test to compute valid value. |
| <int value="3" label="Page"/> |
| </enum> |
| +<enum name="MediaRouterSourceTypes" type="int"> |
| + <int value="1" label="App"/> |
| + <int value="2" label="Tab"/> |
| + <int value="4" label="Desktop"/> |
|
Ilya Sherman
2015/12/28 23:13:00
What happened to 3?
apacible
2015/12/29 01:21:01
I'm following the MediaCastMode values: https://co
|
| +</enum> |
| + |
| +<enum name="MediaRouteType" type="int"> |
| + <int value="0" label="Local"/> |
| + <int value="1" label="Remote"/> |
| +</enum> |
| + |
| <enum name="MediaSessionActionSource" type="int"> |
| <int value="0" label="Media Notification"/> |
| <int value="1" label="MediaSession (Android)"/> |
