Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issue 1548253002: X87: [runtime] Introduce dedicated JSBoundFunction to represent bound functions. (Closed)

Created:
4 years, 12 months ago by zhengxing.li
Modified:
4 years, 12 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [runtime] Introduce dedicated JSBoundFunction to represent bound functions. port 97def8070cbb979419c041c3732d5e11779f79da (r33044) original commit message: According to the ES2015 specification, bound functions are exotic objects, and thus don't need to be implemented as JSFunctions. So we introduce a new JSBoundFunction type to represent bound functions and make them optimizable. This already improves the performance of calling or constructing bound functions by 10-100x depending on the use case because we avoid the crazy dance between JavaScript and C++ that was implemented in v8natives.js previously. There's still room for improvement in the performance of actually creating bound functions, which is also relevant in practice, but we already have a plan how to accomplish that later. The mips/mips64 ports were contributed by akos.palfi@imgtec.com. BUG= Committed: https://crrev.com/37d1dd823baa754ba45510c5a71236a29f72423b Cr-Commit-Position: refs/heads/master@{#33046}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+168 lines, -10 lines) Patch
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/x87/builtins-x87.cc View 4 chunks +150 lines, -0 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M src/x87/macro-assembler-x87.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/x87/macro-assembler-x87.cc View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, Thanks!
4 years, 12 months ago (2015-12-28 04:09:23 UTC) #2
Weiliang
lgtm
4 years, 12 months ago (2015-12-28 05:57:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1548253002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1548253002/1
4 years, 12 months ago (2015-12-28 05:57:58 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 12 months ago (2015-12-28 06:18:44 UTC) #6
commit-bot: I haz the power
4 years, 12 months ago (2015-12-28 06:19:04 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/37d1dd823baa754ba45510c5a71236a29f72423b
Cr-Commit-Position: refs/heads/master@{#33046}

Powered by Google App Engine
This is Rietveld 408576698