Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: third_party/libaddressinput/chromium/override/basictypes_override.h

Issue 1548233002: Switch to standard integer types in third_party/libaddressinput/chromium/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/libaddressinput/chromium/override/basictypes_override.h
diff --git a/third_party/libaddressinput/chromium/override/basictypes_override.h b/third_party/libaddressinput/chromium/override/basictypes_override.h
index 1a8274ffcf3f4924a169742a820dbc1e6059340d..651f506c7903c742011bc169670bef8bd5dd8113 100644
--- a/third_party/libaddressinput/chromium/override/basictypes_override.h
+++ b/third_party/libaddressinput/chromium/override/basictypes_override.h
@@ -5,8 +5,26 @@
#ifndef THIRD_PARTY_LIBADDRESSINPUT_CHROMIUM_BASICTYPES_OVERRIDE_H_
#define THIRD_PARTY_LIBADDRESSINPUT_CHROMIUM_BASICTYPES_OVERRIDE_H_
-#include "base/basictypes.h"
+#include <limits.h>
+#include <stddef.h>
+#include <stdint.h>
+
+#include "base/macros.h"
+
+// There is no more base/basictypes.h in Chromium. Even though libaddressinput
+// has its own "basictypes.h" that defines a whole host of custom integers of
+// specific lengths, the only one actually used is |uint32| in util/md5.cc. So
+// here you go:
+
+typedef uint32_t uint32;
+
+// TODO: Switch libaddressinput to |uint32_t|.
+
+// Also, Chromium uses the C++11 |static_assert|, so here's a definition for the
+// old COMPILE_ASSERT:
#define COMPILE_ASSERT(expr, msg) static_assert(expr, #msg)
+// TODO: Switch libaddressinput to |static_assert|.
+
#endif // THIRD_PARTY_LIBADDRESSINPUT_CHROMIUM_BASICTYPES_OVERRIDE_H_
« no previous file with comments | « third_party/libaddressinput/chromium/json.cc ('k') | third_party/libaddressinput/chromium/storage_test_runner.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698