components/update_client/update_checker_unittest.cc - Issue 1548203002: Convert Pass()→std::move() in //components/[n-z]*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/update_client/update_checker_unittest.cc

Issue 1548203002: Convert Pass()→std::move() in //components/[n-z]* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix bad headers Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/update_client/update_checker_unittest.cc

diff --git a/components/update_client/update_checker_unittest.cc b/components/update_client/update_checker_unittest.cc

index 0bea798595da79d75701ae8b2ffc42cc0574e20f..f45eb3d5cbf7b3e36333f8ef8688536d4d7a44d6 100644

--- a/components/update_client/update_checker_unittest.cc

+++ b/components/update_client/update_checker_unittest.cc

@@ -166,7 +166,7 @@ TEST_F(UpdateCheckerTest, UpdateCheckSuccess) {

EXPECT_TRUE(post_interceptor_->ExpectRequest(

new PartialMatch("updatecheck"), test_file("updatecheck_reply_1.xml")));

- update_checker_ = UpdateChecker::Create(*config_).Pass();

+ update_checker_ = UpdateChecker::Create(*config_);

CrxUpdateItem item(BuildCrxUpdateItem());

std::vector<CrxUpdateItem*> items_to_check;

@@ -212,7 +212,7 @@ TEST_F(UpdateCheckerTest, UpdateCheckError) {

EXPECT_TRUE(

post_interceptor_->ExpectRequest(new PartialMatch("updatecheck"), 403));

- update_checker_ = UpdateChecker::Create(*config_).Pass();

+ update_checker_ = UpdateChecker::Create(*config_);

CrxUpdateItem item(BuildCrxUpdateItem());

std::vector<CrxUpdateItem*> items_to_check;