components/policy/core/common/remote_commands/remote_command_job.cc - Issue 1548203002: Convert Pass()→std::move() in //components/[n-z]*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/policy/core/common/remote_commands/remote_command_job.cc

Issue 1548203002: Convert Pass()→std::move() in //components/[n-z]* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix bad headers Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/policy/core/common/policy_service_impl_unittest.cc ('k') | components/policy/core/common/remote_commands/remote_commands_queue.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/policy/core/common/remote_commands/remote_command_job.cc

diff --git a/components/policy/core/common/remote_commands/remote_command_job.cc b/components/policy/core/common/remote_commands/remote_command_job.cc

index 37c8978d2ac915bb946e5acb25d16516cf77c493..64f897f13a8cf62536b4ff4b9d70f8e4522d567d 100644

--- a/components/policy/core/common/remote_commands/remote_command_job.cc

+++ b/components/policy/core/common/remote_commands/remote_command_job.cc

@@ -4,6 +4,8 @@

#include "components/policy/core/common/remote_commands/remote_command_job.h"

+#include <utility>

#include "base/bind.h"

#include "base/logging.h"

@@ -120,7 +122,7 @@ scoped_ptr<std::string> RemoteCommandJob::GetResultPayload() const {

if (!result_payload_)

return nullptr;

- return result_payload_->Serialize().Pass();

+ return result_payload_->Serialize();

}

RemoteCommandJob::RemoteCommandJob()

@@ -145,7 +147,7 @@ void RemoteCommandJob::OnCommandExecutionFinishedWithResult(

DCHECK_EQ(RUNNING, status_);

status_ = succeeded ? SUCCEEDED : FAILED;

- result_payload_ = result_payload.Pass();

+ result_payload_ = std::move(result_payload);

if (!finished_callback_.is_null())

finished_callback_.Run();