Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Unified Diff: components/password_manager/core/browser/password_store_unittest.cc

Issue 1548203002: Convert Pass()→std::move() in //components/[n-z]* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix bad headers Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_store_unittest.cc
diff --git a/components/password_manager/core/browser/password_store_unittest.cc b/components/password_manager/core/browser/password_store_unittest.cc
index 07ce31bcae443b3168cfcb39f163316cb8b72af9..7607c593c7b69cba422ce1020810a6d09ecc6c2b 100644
--- a/components/password_manager/core/browser/password_store_unittest.cc
+++ b/components/password_manager/core/browser/password_store_unittest.cc
@@ -8,6 +8,7 @@
// passwords. This will not be needed anymore if crbug.com/466638 is fixed.
#include <stddef.h>
+#include <utility>
#include "base/bind.h"
#include "base/files/scoped_temp_dir.h"
@@ -169,8 +170,7 @@ TEST_F(PasswordStoreTest, IgnoreOldWwwGoogleLogins) {
// Build the forms vector and add the forms to the store.
ScopedVector<PasswordForm> all_forms;
for (size_t i = 0; i < arraysize(form_data); ++i) {
- all_forms.push_back(
- CreatePasswordFormFromDataForTesting(form_data[i]).Pass());
+ all_forms.push_back(CreatePasswordFormFromDataForTesting(form_data[i]));
store->AddLogin(*all_forms.back());
}
base::MessageLoop::current()->RunUntilIdle();
@@ -340,7 +340,7 @@ TEST_F(PasswordStoreTest, UpdateLoginPrimaryKeyFields) {
MockPasswordStoreConsumer mock_consumer;
ScopedVector<autofill::PasswordForm> expected_forms;
- expected_forms.push_back(new_form.Pass());
+ expected_forms.push_back(std::move(new_form));
EXPECT_CALL(mock_consumer,
OnGetPasswordStoreResultsConstRef(
UnorderedPasswordFormElementsAre(expected_forms.get())));

Powered by Google App Engine
This is Rietveld 408576698