Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Unified Diff: components/password_manager/core/browser/password_form_manager.cc

Issue 1548203002: Convert Pass()→std::move() in //components/[n-z]* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix bad headers Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_form_manager.cc
diff --git a/components/password_manager/core/browser/password_form_manager.cc b/components/password_manager/core/browser/password_form_manager.cc
index 7a4f64958542c69d1f7b6f0a2b3fced1e21d58b4..9ff8533e788f582b3943e37850d76cf3aa8bc8f5 100644
--- a/components/password_manager/core/browser/password_form_manager.cc
+++ b/components/password_manager/core/browser/password_form_manager.cc
@@ -264,7 +264,7 @@ void PasswordFormManager::ProvisionallySave(
mutable_provisionally_saved_form->username_element.clear();
is_possible_change_password_form_without_username_ = true;
}
- provisionally_saved_form_ = mutable_provisionally_saved_form.Pass();
+ provisionally_saved_form_ = std::move(mutable_provisionally_saved_form);
other_possible_username_action_ = action;
if (HasCompletedMatching())
@@ -405,7 +405,7 @@ void PasswordFormManager::OnRequestDone(
logins_result.end());
}
logins_result =
- client_->GetStoreResultFilter()->FilterResults(logins_result.Pass());
+ client_->GetStoreResultFilter()->FilterResults(std::move(logins_result));
// Deal with blacklisted forms.
auto begin_blacklisted = std::partition(
@@ -476,9 +476,9 @@ void PasswordFormManager::OnRequestDone(
is_credential_protected |= IsValidAndroidFacetURI(login->signon_realm);
if (is_credential_protected)
- protected_credentials.push_back(login.Pass());
+ protected_credentials.push_back(std::move(login));
else
- not_best_matches_.push_back(login.Pass());
+ not_best_matches_.push_back(std::move(login));
continue;
}
@@ -506,7 +506,7 @@ void PasswordFormManager::OnRequestDone(
if (best_matches_.find(username) == best_matches_.end())
best_matches_.insert(std::make_pair(username, std::move(protege)));
else
- not_best_matches_.push_back(protege.Pass());
+ not_best_matches_.push_back(std::move(protege));
}
UMA_HISTOGRAM_COUNTS("PasswordManager.NumPasswordsNotShown",
@@ -603,7 +603,7 @@ void PasswordFormManager::OnGetPasswordStoreResults(
}
if (!results.empty())
- OnRequestDone(results.Pass());
+ OnRequestDone(std::move(results));
state_ = POST_MATCHING_PHASE;
// If password store was slow and provisionally saved form is already here

Powered by Google App Engine
This is Rietveld 408576698