Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Side by Side Diff: components/version_ui/version_handler_helper.cc

Issue 1548203002: Convert Pass()→std::move() in //components/[n-z]* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix bad headers Created 4 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/version_ui/version_handler_helper.h" 5 #include "components/version_ui/version_handler_helper.h"
6 6
7 #include <utility>
7 #include <vector> 8 #include <vector>
8 9
9 #include "base/metrics/field_trial.h" 10 #include "base/metrics/field_trial.h"
10 #include "base/strings/string_util.h" 11 #include "base/strings/string_util.h"
11 #include "base/values.h" 12 #include "base/values.h"
12 #include "components/variations/active_field_trials.h" 13 #include "components/variations/active_field_trials.h"
13 14
14 namespace version_ui { 15 namespace version_ui {
15 16
16 scoped_ptr<base::Value> GetVariationsList() { 17 scoped_ptr<base::Value> GetVariationsList() {
(...skipping 14 matching lines...) Expand all
31 // In release mode, display the hashes only. 32 // In release mode, display the hashes only.
32 variations::GetFieldTrialActiveGroupIdsAsStrings(&variations); 33 variations::GetFieldTrialActiveGroupIdsAsStrings(&variations);
33 #endif 34 #endif
34 35
35 scoped_ptr<base::ListValue> variations_list(new base::ListValue); 36 scoped_ptr<base::ListValue> variations_list(new base::ListValue);
36 for (std::vector<std::string>::const_iterator it = variations.begin(); 37 for (std::vector<std::string>::const_iterator it = variations.begin();
37 it != variations.end(); ++it) { 38 it != variations.end(); ++it) {
38 variations_list->Append(new base::StringValue(*it)); 39 variations_list->Append(new base::StringValue(*it));
39 } 40 }
40 41
41 return variations_list.Pass(); 42 return std::move(variations_list);
42 } 43 }
43 44
44 } // namespace version_ui 45 } // namespace version_ui
OLDNEW
« no previous file with comments | « components/variations/variations_seed_processor_unittest.cc ('k') | components/visitedlink/browser/visitedlink_master.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698