Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Side by Side Diff: components/policy/core/common/cloud/cloud_policy_validator_unittest.cc

Issue 1548203002: Convert Pass()→std::move() in //components/[n-z]* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix bad headers Created 4 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/policy/core/common/cloud/cloud_policy_validator.h"
6
5 #include <stdint.h> 7 #include <stdint.h>
6 8 #include <utility>
7 #include <vector> 9 #include <vector>
8 10
9 #include "base/bind.h" 11 #include "base/bind.h"
10 #include "base/macros.h" 12 #include "base/macros.h"
11 #include "base/memory/scoped_ptr.h" 13 #include "base/memory/scoped_ptr.h"
12 #include "base/message_loop/message_loop.h" 14 #include "base/message_loop/message_loop.h"
13 #include "base/single_thread_task_runner.h" 15 #include "base/single_thread_task_runner.h"
14 #include "base/strings/string_util.h" 16 #include "base/strings/string_util.h"
15 #include "base/thread_task_runner_handle.h" 17 #include "base/thread_task_runner_handle.h"
16 #include "build/build_config.h" 18 #include "build/build_config.h"
17 #include "components/policy/core/common/cloud/cloud_policy_constants.h" 19 #include "components/policy/core/common/cloud/cloud_policy_constants.h"
18 #include "components/policy/core/common/cloud/cloud_policy_validator.h"
19 #include "components/policy/core/common/cloud/policy_builder.h" 20 #include "components/policy/core/common/cloud/policy_builder.h"
20 #include "components/policy/core/common/policy_switches.h" 21 #include "components/policy/core/common/policy_switches.h"
21 #include "crypto/rsa_private_key.h" 22 #include "crypto/rsa_private_key.h"
22 #include "policy/proto/device_management_backend.pb.h" 23 #include "policy/proto/device_management_backend.pb.h"
23 #include "testing/gmock/include/gmock/gmock.h" 24 #include "testing/gmock/include/gmock/gmock.h"
24 #include "testing/gtest/include/gtest/gtest.h" 25 #include "testing/gtest/include/gtest/gtest.h"
25 26
26 namespace em = enterprise_management; 27 namespace em = enterprise_management;
27 28
28 using testing::Invoke; 29 using testing::Invoke;
(...skipping 24 matching lines...) Expand all
53 54
54 void Validate(testing::Action<void(UserCloudPolicyValidator*)> check_action) { 55 void Validate(testing::Action<void(UserCloudPolicyValidator*)> check_action) {
55 policy_.Build(); 56 policy_.Build();
56 ValidatePolicy(check_action, policy_.GetCopy()); 57 ValidatePolicy(check_action, policy_.GetCopy());
57 } 58 }
58 59
59 void ValidatePolicy( 60 void ValidatePolicy(
60 testing::Action<void(UserCloudPolicyValidator*)> check_action, 61 testing::Action<void(UserCloudPolicyValidator*)> check_action,
61 scoped_ptr<enterprise_management::PolicyFetchResponse> policy_response) { 62 scoped_ptr<enterprise_management::PolicyFetchResponse> policy_response) {
62 // Create a validator. 63 // Create a validator.
63 scoped_ptr<UserCloudPolicyValidator> validator = CreateValidator( 64 scoped_ptr<UserCloudPolicyValidator> validator =
64 policy_response.Pass()); 65 CreateValidator(std::move(policy_response));
65 66
66 // Run validation and check the result. 67 // Run validation and check the result.
67 EXPECT_CALL(*this, ValidationCompletion(validator.get())).WillOnce( 68 EXPECT_CALL(*this, ValidationCompletion(validator.get())).WillOnce(
68 check_action); 69 check_action);
69 validator.release()->StartValidation( 70 validator.release()->StartValidation(
70 base::Bind(&CloudPolicyValidatorTest::ValidationCompletion, 71 base::Bind(&CloudPolicyValidatorTest::ValidationCompletion,
71 base::Unretained(this))); 72 base::Unretained(this)));
72 loop_.RunUntilIdle(); 73 loop_.RunUntilIdle();
73 Mock::VerifyAndClearExpectations(this); 74 Mock::VerifyAndClearExpectations(this);
74 } 75 }
75 76
76 scoped_ptr<UserCloudPolicyValidator> CreateValidator( 77 scoped_ptr<UserCloudPolicyValidator> CreateValidator(
77 scoped_ptr<enterprise_management::PolicyFetchResponse> policy_response) { 78 scoped_ptr<enterprise_management::PolicyFetchResponse> policy_response) {
78 std::vector<uint8_t> public_key_bytes; 79 std::vector<uint8_t> public_key_bytes;
79 EXPECT_TRUE( 80 EXPECT_TRUE(
80 PolicyBuilder::CreateTestSigningKey()->ExportPublicKey( 81 PolicyBuilder::CreateTestSigningKey()->ExportPublicKey(
81 &public_key_bytes)); 82 &public_key_bytes));
82 83
83 // Convert from bytes to string format (which is what ValidateSignature() 84 // Convert from bytes to string format (which is what ValidateSignature()
84 // takes). 85 // takes).
85 std::string public_key = 86 std::string public_key =
86 std::string(reinterpret_cast<const char*>(public_key_bytes.data()), 87 std::string(reinterpret_cast<const char*>(public_key_bytes.data()),
87 public_key_bytes.size()); 88 public_key_bytes.size());
88 89
89 UserCloudPolicyValidator* validator = UserCloudPolicyValidator::Create( 90 UserCloudPolicyValidator* validator = UserCloudPolicyValidator::Create(
90 policy_response.Pass(), base::ThreadTaskRunnerHandle::Get()); 91 std::move(policy_response), base::ThreadTaskRunnerHandle::Get());
91 validator->ValidateTimestamp(timestamp_, timestamp_, 92 validator->ValidateTimestamp(timestamp_, timestamp_,
92 timestamp_option_); 93 timestamp_option_);
93 validator->ValidateUsername(PolicyBuilder::kFakeUsername, true); 94 validator->ValidateUsername(PolicyBuilder::kFakeUsername, true);
94 if (!owning_domain_.empty()) 95 if (!owning_domain_.empty())
95 validator->ValidateDomain(owning_domain_); 96 validator->ValidateDomain(owning_domain_);
96 validator->ValidateDMToken(existing_dm_token_, ignore_missing_dm_token_); 97 validator->ValidateDMToken(existing_dm_token_, ignore_missing_dm_token_);
97 validator->ValidatePolicyType(dm_protocol::kChromeUserPolicyType); 98 validator->ValidatePolicyType(dm_protocol::kChromeUserPolicyType);
98 validator->ValidatePayload(); 99 validator->ValidatePayload();
99 validator->ValidateCachedKey(public_key, 100 validator->ValidateCachedKey(public_key,
100 cached_key_signature_, 101 cached_key_signature_,
(...skipping 281 matching lines...) Expand 10 before | Expand all | Expand 10 after
382 383
383 TEST_F(CloudPolicyValidatorTest, NoRotation) { 384 TEST_F(CloudPolicyValidatorTest, NoRotation) {
384 allow_key_rotation_ = false; 385 allow_key_rotation_ = false;
385 policy_.UnsetNewSigningKey(); 386 policy_.UnsetNewSigningKey();
386 Validate(CheckStatus(CloudPolicyValidatorBase::VALIDATION_OK)); 387 Validate(CheckStatus(CloudPolicyValidatorBase::VALIDATION_OK));
387 } 388 }
388 389
389 } // namespace 390 } // namespace
390 391
391 } // namespace policy 392 } // namespace policy
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698