Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(603)

Side by Side Diff: components/password_manager/core/browser/password_manager.cc

Issue 1548203002: Convert Pass()→std::move() in //components/[n-z]* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix bad headers Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/password_manager/core/browser/password_manager.h" 5 #include "components/password_manager/core/browser/password_manager.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8
9 #include <map> 8 #include <map>
9 #include <utility>
10 10
11 #include "base/command_line.h" 11 #include "base/command_line.h"
12 #include "base/metrics/field_trial.h" 12 #include "base/metrics/field_trial.h"
13 #include "base/metrics/histogram_macros.h" 13 #include "base/metrics/histogram_macros.h"
14 #include "base/prefs/pref_service.h" 14 #include "base/prefs/pref_service.h"
15 #include "base/strings/string_util.h" 15 #include "base/strings/string_util.h"
16 #include "base/strings/utf_string_conversions.h" 16 #include "base/strings/utf_string_conversions.h"
17 #include "base/threading/platform_thread.h" 17 #include "base/threading/platform_thread.h"
18 #include "build/build_config.h" 18 #include "build/build_config.h"
19 #include "components/autofill/core/browser/autofill_field.h" 19 #include "components/autofill/core/browser/autofill_field.h"
(...skipping 677 matching lines...) Expand 10 before | Expand all | Expand 10 after
697 empty_password); 697 empty_password);
698 if (logger) 698 if (logger)
699 logger->LogMessage(Logger::STRING_DECISION_ASK); 699 logger->LogMessage(Logger::STRING_DECISION_ASK);
700 bool update_password = 700 bool update_password =
701 (!provisional_save_manager_->best_matches().empty() && 701 (!provisional_save_manager_->best_matches().empty() &&
702 provisional_save_manager_ 702 provisional_save_manager_
703 ->is_possible_change_password_form_without_username()) || 703 ->is_possible_change_password_form_without_username()) ||
704 provisional_save_manager_->password_overridden() || 704 provisional_save_manager_->password_overridden() ||
705 provisional_save_manager_->retry_password_form_password_update(); 705 provisional_save_manager_->retry_password_form_password_update();
706 if (client_->PromptUserToSaveOrUpdatePassword( 706 if (client_->PromptUserToSaveOrUpdatePassword(
707 provisional_save_manager_.Pass(), 707 std::move(provisional_save_manager_),
708 CredentialSourceType::CREDENTIAL_SOURCE_PASSWORD_MANAGER, 708 CredentialSourceType::CREDENTIAL_SOURCE_PASSWORD_MANAGER,
709 update_password)) { 709 update_password)) {
710 if (logger) 710 if (logger)
711 logger->LogMessage(Logger::STRING_SHOW_PASSWORD_PROMPT); 711 logger->LogMessage(Logger::STRING_SHOW_PASSWORD_PROMPT);
712 } 712 }
713 } else { 713 } else {
714 if (logger) 714 if (logger)
715 logger->LogMessage(Logger::STRING_DECISION_SAVE); 715 logger->LogMessage(Logger::STRING_DECISION_SAVE);
716 provisional_save_manager_->Save(); 716 provisional_save_manager_->Save();
717 717
718 if (provisional_save_manager_->has_generated_password()) { 718 if (provisional_save_manager_->has_generated_password()) {
719 client_->AutomaticPasswordSave(provisional_save_manager_.Pass()); 719 client_->AutomaticPasswordSave(std::move(provisional_save_manager_));
720 } else { 720 } else {
721 provisional_save_manager_.reset(); 721 provisional_save_manager_.reset();
722 } 722 }
723 } 723 }
724 } 724 }
725 725
726 bool PasswordManager::OtherPossibleUsernamesEnabled() const { 726 bool PasswordManager::OtherPossibleUsernamesEnabled() const {
727 return false; 727 return false;
728 } 728 }
729 729
(...skipping 108 matching lines...) Expand 10 before | Expand all | Expand 10 after
838 matched_manager_it = iter; 838 matched_manager_it = iter;
839 current_match_result = result; 839 current_match_result = result;
840 } 840 }
841 } 841 }
842 if (matched_manager_it != pending_login_managers_.end()) 842 if (matched_manager_it != pending_login_managers_.end())
843 return *matched_manager_it; 843 return *matched_manager_it;
844 return nullptr; 844 return nullptr;
845 } 845 }
846 846
847 } // namespace password_manager 847 } // namespace password_manager
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698