Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Side by Side Diff: components/page_load_metrics/renderer/page_timing_metrics_sender.cc

Issue 1548203002: Convert Pass()→std::move() in //components/[n-z]* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix bad headers Created 4 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/page_load_metrics/renderer/page_timing_metrics_sender.h"
6
7 #include <utility>
8
5 #include "base/callback.h" 9 #include "base/callback.h"
6 #include "base/time/time.h" 10 #include "base/time/time.h"
7 #include "base/timer/timer.h" 11 #include "base/timer/timer.h"
8 #include "components/page_load_metrics/common/page_load_metrics_messages.h" 12 #include "components/page_load_metrics/common/page_load_metrics_messages.h"
9 #include "components/page_load_metrics/renderer/page_timing_metrics_sender.h"
10 #include "ipc/ipc_sender.h" 13 #include "ipc/ipc_sender.h"
11 14
12 namespace page_load_metrics { 15 namespace page_load_metrics {
13 16
14 namespace { 17 namespace {
15 const int kTimerDelayMillis = 1000; 18 const int kTimerDelayMillis = 1000;
16 } // namespace 19 } // namespace
17 20
18 PageTimingMetricsSender::PageTimingMetricsSender(IPC::Sender* ipc_sender, 21 PageTimingMetricsSender::PageTimingMetricsSender(IPC::Sender* ipc_sender,
19 int routing_id, 22 int routing_id,
20 scoped_ptr<base::Timer> timer) 23 scoped_ptr<base::Timer> timer)
21 : ipc_sender_(ipc_sender), routing_id_(routing_id), timer_(timer.Pass()) {} 24 : ipc_sender_(ipc_sender),
25 routing_id_(routing_id),
26 timer_(std::move(timer)) {}
22 27
23 // On destruction, we want to send any data we have if we have a timer 28 // On destruction, we want to send any data we have if we have a timer
24 // currently running (and thus are talking to a browser process) 29 // currently running (and thus are talking to a browser process)
25 PageTimingMetricsSender::~PageTimingMetricsSender() { 30 PageTimingMetricsSender::~PageTimingMetricsSender() {
26 if (timer_->IsRunning()) { 31 if (timer_->IsRunning()) {
27 timer_->Stop(); 32 timer_->Stop();
28 SendNow(); 33 SendNow();
29 } 34 }
30 } 35 }
31 36
(...skipping 16 matching lines...) Expand all
48 FROM_HERE, base::TimeDelta::FromMilliseconds(kTimerDelayMillis), 53 FROM_HERE, base::TimeDelta::FromMilliseconds(kTimerDelayMillis),
49 base::Bind(&PageTimingMetricsSender::SendNow, base::Unretained(this))); 54 base::Bind(&PageTimingMetricsSender::SendNow, base::Unretained(this)));
50 } 55 }
51 56
52 void PageTimingMetricsSender::SendNow() { 57 void PageTimingMetricsSender::SendNow() {
53 ipc_sender_->Send( 58 ipc_sender_->Send(
54 new PageLoadMetricsMsg_TimingUpdated(routing_id_, last_timing_)); 59 new PageLoadMetricsMsg_TimingUpdated(routing_id_, last_timing_));
55 } 60 }
56 61
57 } // namespace page_load_metrics 62 } // namespace page_load_metrics
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698