Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Issue 1548173002: Enable ui_base_unittests to run on swarming on gyp-based bots (Closed)

Created:
4 years, 12 months ago by Nico
Modified:
4 years, 12 months ago
Reviewers:
hans, M-A Ruel
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable ui_base_unittests to run on swarming on gyp-based bots Follow-up to https://codereview.chromium.org/1547153002, to unbreak the isolate_tests step on the ClangToTMacAsan builder. BUG=98637, 503241, 572240 TBR=maruel@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/9cc09a13cb2f11cf05cf065b1acd26c1e384d5f0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M build/gn_migration.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Nico
4 years, 12 months ago (2015-12-26 14:58:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1548173002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1548173002/1
4 years, 12 months ago (2015-12-26 14:59:05 UTC) #5
Nico
+hans since he seems around :-)
4 years, 12 months ago (2015-12-26 15:35:03 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9cc09a13cb2f11cf05cf065b1acd26c1e384d5f0 Cr-Commit-Position: refs/heads/master@{#366900}
4 years, 12 months ago (2015-12-26 15:47:18 UTC) #9
Nico
Committed patchset #1 (id:1) manually as 9cc09a13cb2f11cf05cf065b1acd26c1e384d5f0 (presubmit successful).
4 years, 12 months ago (2015-12-26 15:48:01 UTC) #11
hans
4 years, 12 months ago (2015-12-29 08:58:30 UTC) #12
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698