Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Issue 1548163002: exo: Add Surface::SetBufferScale. (Closed)

Created:
4 years, 12 months ago by reveman
Modified:
4 years, 11 months ago
Reviewers:
lpique
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

exo: Add Surface::SetBufferScale. The buffer scale allow clients to supply higher resolution buffer data for use on high resolution displays. BUG=549781 TEST=exo_unittest --gtest_filter=SurfaceTest.SetBufferScale Committed: https://crrev.com/7efa4b0e51409c538d7a05f6f315c51ae3c7f3b6 Cr-Commit-Position: refs/heads/master@{#367797}

Patch Set 1 #

Total comments: 2

Patch Set 2 : use contents_size to determine layer transform #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -5 lines) Patch
M components/exo/surface.h View 2 chunks +9 lines, -0 lines 0 comments Download
M components/exo/surface.cc View 1 5 chunks +19 lines, -4 lines 0 comments Download
M components/exo/surface_unittest.cc View 1 chunk +21 lines, -0 lines 0 comments Download
M components/exo/wayland/server.cc View 1 chunk +9 lines, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
reveman
4 years, 11 months ago (2015-12-28 08:50:54 UTC) #2
lpique
https://codereview.chromium.org/1548163002/diff/1/components/exo/surface.cc File components/exo/surface.cc (right): https://codereview.chromium.org/1548163002/diff/1/components/exo/surface.cc#newcode289 components/exo/surface.cc:289: 1.0f / pending_buffer_scale_)); The call to ScaleToFlooredSize() includes (as ...
4 years, 11 months ago (2016-01-04 19:36:20 UTC) #3
reveman
https://codereview.chromium.org/1548163002/diff/1/components/exo/surface.cc File components/exo/surface.cc (right): https://codereview.chromium.org/1548163002/diff/1/components/exo/surface.cc#newcode289 components/exo/surface.cc:289: 1.0f / pending_buffer_scale_)); On 2016/01/04 at 19:36:20, lpique wrote: ...
4 years, 11 months ago (2016-01-05 09:02:48 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1548163002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1548163002/20001
4 years, 11 months ago (2016-01-05 09:03:03 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-05 09:18:08 UTC) #8
lpique
lgtm
4 years, 11 months ago (2016-01-05 18:52:01 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1548163002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1548163002/20001
4 years, 11 months ago (2016-01-06 08:25:49 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-06 08:30:01 UTC) #12
commit-bot: I haz the power
4 years, 11 months ago (2016-01-06 08:30:58 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7efa4b0e51409c538d7a05f6f315c51ae3c7f3b6
Cr-Commit-Position: refs/heads/master@{#367797}

Powered by Google App Engine
This is Rietveld 408576698