Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1918)

Unified Diff: chrome/utility/media_galleries/pmp_column_reader.h

Issue 1548153002: Switch to standard integer types in chrome/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/utility/media_galleries/pmp_column_reader.h
diff --git a/chrome/utility/media_galleries/pmp_column_reader.h b/chrome/utility/media_galleries/pmp_column_reader.h
index 7fb398ed7f908a117dd91f246b27f3f4481f1cff..7f885eaa925cad1ac4a0e375faccd28d11b9f823 100644
--- a/chrome/utility/media_galleries/pmp_column_reader.h
+++ b/chrome/utility/media_galleries/pmp_column_reader.h
@@ -5,10 +5,12 @@
#ifndef CHROME_UTILITY_MEDIA_GALLERIES_PMP_COLUMN_READER_H_
#define CHROME_UTILITY_MEDIA_GALLERIES_PMP_COLUMN_READER_H_
+#include <stdint.h>
+
#include <string>
#include <vector>
-#include "base/basictypes.h"
+#include "base/macros.h"
#include "base/memory/scoped_ptr.h"
#include "chrome/common/media_galleries/pmp_constants.h"
@@ -32,27 +34,27 @@ class PmpColumnReader {
// These functions read the value of that |row| into |result|.
// Functions return false if the column is of the wrong type or the row
// is out of range. May only be called after successful ReadColumn.
- bool ReadString(const uint32 row, std::string* result) const;
- bool ReadUInt32(const uint32 row, uint32* result) const;
- bool ReadDouble64(const uint32 row, double* result) const;
- bool ReadUInt8(const uint32 row, uint8* result) const;
- bool ReadUInt64(const uint32 row, uint64* result) const;
+ bool ReadString(const uint32_t row, std::string* result) const;
+ bool ReadUInt32(const uint32_t row, uint32_t* result) const;
+ bool ReadDouble64(const uint32_t row, double* result) const;
+ bool ReadUInt8(const uint32_t row, uint8_t* result) const;
+ bool ReadUInt64(const uint32_t row, uint64_t* result) const;
// May only be called after successful ReadColumn.
- uint32 rows_read() const;
+ uint32_t rows_read() const;
private:
bool ParseData(const PmpFieldType expected_type);
// Returns the number of bytes parsed in the body, or, -1 on failure.
- int64 IndexStrings();
+ int64_t IndexStrings();
// Source data
- scoped_ptr<uint8[]> data_;
- int64 length_;
+ scoped_ptr<uint8_t[]> data_;
+ int64_t length_;
// Header data
PmpFieldType field_type_;
- uint32 rows_read_;
+ uint32_t rows_read_;
// Index of string start locations if fields are strings. Empty otherwise.
std::vector<const char*> strings_;
« no previous file with comments | « chrome/utility/media_galleries/picasa_albums_indexer.h ('k') | chrome/utility/media_galleries/pmp_column_reader.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698