Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5887)

Unified Diff: chrome/test/chromedriver/net/port_server_unittest.cc

Issue 1548153002: Switch to standard integer types in chrome/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/chromedriver/net/port_server.cc ('k') | chrome/test/chromedriver/net/sync_websocket_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/net/port_server_unittest.cc
diff --git a/chrome/test/chromedriver/net/port_server_unittest.cc b/chrome/test/chromedriver/net/port_server_unittest.cc
index d711710e5469227998bed6172ecb06ff634964db..6927cfa106112b1b0035be9ef2771dfa5a1af4a6 100644
--- a/chrome/test/chromedriver/net/port_server_unittest.cc
+++ b/chrome/test/chromedriver/net/port_server_unittest.cc
@@ -2,6 +2,10 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
+#include <stddef.h>
+#include <stdint.h>
+#include <string.h>
+
#include <string>
#include "base/bind.h"
@@ -12,6 +16,7 @@
#include "base/synchronization/waitable_event.h"
#include "base/threading/thread.h"
#include "base/time/time.h"
+#include "build/build_config.h"
#include "chrome/test/chromedriver/chrome/status.h"
#include "chrome/test/chromedriver/net/port_server.h"
#include "net/base/sys_addrinfo.h"
@@ -141,7 +146,7 @@ TEST_F(PortServerTest, Reserve) {
std::string request;
RunServer(path, "12345\n", &request);
- uint16 port = 0;
+ uint16_t port = 0;
scoped_ptr<PortReservation> reservation;
Status status = server.ReservePort(&port, &reservation);
ASSERT_EQ(kOk, status.code()) << status.message();
@@ -155,7 +160,7 @@ TEST_F(PortServerTest, ReserveResetReserve) {
std::string request;
RunServer(path, "12345\n", &request);
- uint16 port = 0;
+ uint16_t port = 0;
scoped_ptr<PortReservation> reservation;
Status status = server.ReservePort(&port, &reservation);
ASSERT_EQ(kOk, status.code()) << status.message();
@@ -174,7 +179,7 @@ TEST_F(PortServerTest, ReserveReserve) {
std::string request;
RunServer(path, "12345\n", &request);
- uint16 port = 0;
+ uint16_t port = 0;
scoped_ptr<PortReservation> reservation;
Status status = server.ReservePort(&port, &reservation);
ASSERT_EQ(kOk, status.code()) << status.message();
@@ -189,7 +194,7 @@ TEST_F(PortServerTest, ReserveReserve) {
TEST(PortManagerTest, ReservePort) {
PortManager mgr(15000, 16000);
- uint16 port = 0;
+ uint16_t port = 0;
scoped_ptr<PortReservation> reservation;
Status status = mgr.ReservePort(&port, &reservation);
ASSERT_EQ(kOk, status.code()) << status.message();
@@ -201,7 +206,7 @@ TEST(PortManagerTest, ReservePort) {
TEST(PortManagerTest, ReservePortFromPool) {
PortManager mgr(15000, 16000);
- uint16 first_port = 0, port = 1;
+ uint16_t first_port = 0, port = 1;
for (int i = 0; i < 10; i++) {
scoped_ptr<PortReservation> reservation;
Status status = mgr.ReservePortFromPool(&port, &reservation);
« no previous file with comments | « chrome/test/chromedriver/net/port_server.cc ('k') | chrome/test/chromedriver/net/sync_websocket_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698