Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4392)

Unified Diff: chrome/installer/util/wmi.cc

Issue 1548153002: Switch to standard integer types in chrome/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/installer/util/util_constants.h ('k') | chrome/installer/util/work_item.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/util/wmi.cc
diff --git a/chrome/installer/util/wmi.cc b/chrome/installer/util/wmi.cc
index 2040ceb05e39700c4d8e5a0083f111a6e9cf238c..2b8c9f91fca5b349dae6df43cabcdef5adaf0588 100644
--- a/chrome/installer/util/wmi.cc
+++ b/chrome/installer/util/wmi.cc
@@ -5,8 +5,8 @@
#include "chrome/installer/util/wmi.h"
#include <windows.h>
+#include <stdint.h>
-#include "base/basictypes.h"
#include "base/win/scoped_bstr.h"
#include "base/win/scoped_comptr.h"
#include "base/win/scoped_variant.h"
@@ -85,8 +85,8 @@ bool SetParameter(IWbemClassObject* class_method,
// CIM class is documented here:
// http://msdn2.microsoft.com/en-us/library/aa389388(VS.85).aspx
// NOTE: The documentation for the Create method suggests that the ProcessId
-// parameter and return value are of type uint32, but when we call the method
-// the values in the returned out_params, are VT_I4, which is int32.
+// parameter and return value are of type uint32_t, but when we call the method
+// the values in the returned out_params, are VT_I4, which is int32_t.
bool WMIProcess::Launch(const std::wstring& command_line, int* process_id) {
base::win::ScopedComPtr<IWbemServices> wmi_local;
@@ -113,7 +113,8 @@ bool WMIProcess::Launch(const std::wstring& command_line, int* process_id) {
if (FAILED(hr))
return false;
- // We're only expecting int32 or uint32 values, so no need for ScopedVariant.
+ // We're only expecting int32_t or uint32_t values, so no need for
+ // ScopedVariant.
VARIANT ret_value = {{{VT_EMPTY}}};
hr = out_params->Get(L"ReturnValue", 0, &ret_value, NULL, 0);
if (FAILED(hr) || 0 != V_I4(&ret_value))
« no previous file with comments | « chrome/installer/util/util_constants.h ('k') | chrome/installer/util/work_item.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698