Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10473)

Unified Diff: chrome/installer/util/shell_util.cc

Issue 1548153002: Switch to standard integer types in chrome/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/installer/util/shell_util.h ('k') | chrome/installer/util/shell_util_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/util/shell_util.cc
diff --git a/chrome/installer/util/shell_util.cc b/chrome/installer/util/shell_util.cc
index 4a43d55e6ce811bccf354cbdc2deda0543b59022..6051eba27ab6845612c5c676faf0c3c67d209d0e 100644
--- a/chrome/installer/util/shell_util.cc
+++ b/chrome/installer/util/shell_util.cc
@@ -23,6 +23,7 @@
#include "base/files/file_util.h"
#include "base/lazy_instance.h"
#include "base/logging.h"
+#include "base/macros.h"
#include "base/md5.h"
#include "base/memory/scoped_ptr.h"
#include "base/memory/scoped_vector.h"
@@ -618,7 +619,7 @@ void GetXPStyleDefaultBrowserUserEntries(BrowserDistribution* dist,
// |removal_flag_| is set). |look_for_in| is passed to
// RegistryEntry::ExistsInRegistry(). Documentation for it can be found there.
bool AreEntriesAsDesired(const ScopedVector<RegistryEntry>& entries,
- uint32 look_for_in) {
+ uint32_t look_for_in) {
for (const auto* entry : entries) {
if (entry->ExistsInRegistry(look_for_in) != !entry->IsFlaggedForRemoval())
return false;
@@ -639,7 +640,7 @@ bool AreEntriesAsDesired(const ScopedVector<RegistryEntry>& entries,
bool IsChromeRegistered(BrowserDistribution* dist,
const base::FilePath& chrome_exe,
const base::string16& suffix,
- uint32 look_for_in) {
+ uint32_t look_for_in) {
ScopedVector<RegistryEntry> entries;
GetChromeProgIdEntries(dist, chrome_exe, suffix, &entries);
GetShellIntegrationEntries(dist, chrome_exe, suffix, &entries);
@@ -653,7 +654,7 @@ bool IsChromeRegistered(BrowserDistribution* dist,
bool IsChromeRegisteredForProtocol(BrowserDistribution* dist,
const base::string16& suffix,
const base::string16& protocol,
- uint32 look_for_in) {
+ uint32_t look_for_in) {
ScopedVector<RegistryEntry> entries;
GetProtocolCapabilityEntries(dist, suffix, protocol, &entries);
return AreEntriesAsDesired(entries, look_for_in);
@@ -2033,8 +2034,8 @@ bool ShellUtil::RegisterChromeBrowser(BrowserDistribution* dist,
// install is also present, it will lead IsChromeRegistered() to think this
// system-level install isn't registered properly as it is shadowed by the
// user-level install's registrations).
- uint32 look_for_in = user_level ?
- RegistryEntry::LOOK_IN_HKCU_THEN_HKLM : RegistryEntry::LOOK_IN_HKLM;
+ uint32_t look_for_in = user_level ? RegistryEntry::LOOK_IN_HKCU_THEN_HKLM
+ : RegistryEntry::LOOK_IN_HKLM;
// Check if chrome is already registered with this suffix.
if (IsChromeRegistered(dist, chrome_exe, suffix, look_for_in))
@@ -2115,8 +2116,8 @@ bool ShellUtil::RegisterChromeForProtocol(BrowserDistribution* dist,
// install is also present, it could lead IsChromeRegisteredForProtocol() to
// think this system-level install isn't registered properly as it may be
// shadowed by the user-level install's registrations).
- uint32 look_for_in = user_level ?
- RegistryEntry::LOOK_IN_HKCU_THEN_HKLM : RegistryEntry::LOOK_IN_HKLM;
+ uint32_t look_for_in = user_level ? RegistryEntry::LOOK_IN_HKCU_THEN_HKLM
+ : RegistryEntry::LOOK_IN_HKLM;
// Check if chrome is already registered with this suffix.
if (IsChromeRegisteredForProtocol(dist, suffix, protocol, look_for_in))
@@ -2225,7 +2226,7 @@ bool ShellUtil::GetOldUserSpecificRegistrySuffix(base::string16* suffix) {
return true;
}
-base::string16 ShellUtil::ByteArrayToBase32(const uint8* bytes, size_t size) {
+base::string16 ShellUtil::ByteArrayToBase32(const uint8_t* bytes, size_t size) {
static const char kEncoding[] = "ABCDEFGHIJKLMNOPQRSTUVWXYZ234567";
// Eliminate special cases first.
@@ -2252,7 +2253,7 @@ base::string16 ShellUtil::ByteArrayToBase32(const uint8* bytes, size_t size) {
// A bit stream which will be read from the left and appended to from the
// right as it's emptied.
- uint16 bit_stream = (bytes[0] << 8) + bytes[1];
+ uint16_t bit_stream = (bytes[0] << 8) + bytes[1];
size_t next_byte_index = 2;
int free_bits = 0;
while (free_bits < 16) {
« no previous file with comments | « chrome/installer/util/shell_util.h ('k') | chrome/installer/util/shell_util_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698