chrome/common/extensions/api/networking_private/networking_private_crypto_unittest.cc - Issue 1548153002: Switch to standard integer types in chrome/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/api/networking_private/networking_private_crypto_unittest.cc

Issue 1548153002: Switch to standard integer types in chrome/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/api/networking_private/networking_private_crypto.cc ('k') | chrome/common/extensions/api/plugins/plugins_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/api/networking_private/networking_private_crypto_unittest.cc

diff --git a/chrome/common/extensions/api/networking_private/networking_private_crypto_unittest.cc b/chrome/common/extensions/api/networking_private/networking_private_crypto_unittest.cc

index 5f5c4466e4778d18d4fc616c19a52a3ecb2a9309..a81d18026e3cb47beeda715c13f39b68c54f7a80 100644

--- a/chrome/common/extensions/api/networking_private/networking_private_crypto_unittest.cc

+++ b/chrome/common/extensions/api/networking_private/networking_private_crypto_unittest.cc

@@ -3,6 +3,8 @@

// found in the LICENSE file.

#include "chrome/common/extensions/api/networking_private/networking_private_crypto.h"

+#include <stdint.h>

#include "base/base64.h"

#include "base/logging.h"

#include "base/strings/stringprintf.h"

@@ -22,7 +24,7 @@ class NetworkingPrivateCryptoTest : public testing::Test {

// |plain| data.

bool VerifyByteString(const std::string& private_key_pem,

const std::string& plain,

- const std::vector<uint8>& encrypted) {

+ const std::vector<uint8_t>& encrypted) {

std::string decrypted;

if (networking_private_crypto::DecryptByteString(

private_key_pem, encrypted, &decrypted))

@@ -206,16 +208,16 @@ TEST_F(NetworkingPrivateCryptoTest, EncryptByteString) {

"e5ZqY4RmsQmv6K0rn5k+UT4qlPeVp1e6LnvO/PcKWOaUvDK59qFZoX4vN+iFUAbk"

"IuvhmL9u/uPWWck="

"-----END PRIVATE KEY-----";

- static const std::vector<uint8> kBadKeyData(5, 111);

+ static const std::vector<uint8_t> kBadKeyData(5, 111);

static const char kTestData[] = "disco boy";

static const char kEmptyData[] = "";

std::string public_key_string;

base::Base64Decode(kPublicKey, &public_key_string);

- std::vector<uint8> public_key(public_key_string.begin(),

- public_key_string.end());

+ std::vector<uint8_t> public_key(public_key_string.begin(),

+ public_key_string.end());

std::string plain;

- std::vector<uint8> encrypted_output;

+ std::vector<uint8_t> encrypted_output;

// Checking basic encryption operation.

plain = kTestData;