chrome/test/chromedriver/logging_unittest.cc - Issue 1548153002: Switch to standard integer types in chrome/.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/chromedriver/logging_unittest.cc

Issue 1548153002: Switch to standard integer types in chrome/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/test/chromedriver/logging.cc ('k') | chrome/test/chromedriver/net/adb_client_socket.h » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

	5 #include <stddef.h>

	6

	7 #include "base/macros.h"

5 #include "base/values.h"	8 #include "base/values.h"

6 #include "chrome/test/chromedriver/capabilities.h"	9 #include "chrome/test/chromedriver/capabilities.h"

7 #include "chrome/test/chromedriver/chrome/devtools_event_listener.h"	10 #include "chrome/test/chromedriver/chrome/devtools_event_listener.h"

8 #include "chrome/test/chromedriver/chrome/log.h"	11 #include "chrome/test/chromedriver/chrome/log.h"

9 #include "chrome/test/chromedriver/chrome/status.h"	12 #include "chrome/test/chromedriver/chrome/status.h"

10 #include "chrome/test/chromedriver/command_listener.h"	13 #include "chrome/test/chromedriver/command_listener.h"

11 #include "chrome/test/chromedriver/logging.h"	14 #include "chrome/test/chromedriver/logging.h"

12 #include "chrome/test/chromedriver/session.h"	15 #include "chrome/test/chromedriver/session.h"

13 #include "testing/gtest/include/gtest/gtest.h"	16 #include "testing/gtest/include/gtest/gtest.h"

14	17

(...skipping 143 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
158 ASSERT_TRUE(entry.empty());	161 ASSERT_TRUE(entry.empty());

159	162

160 log.AddEntry(Log::kInfo, "info message");	163 log.AddEntry(Log::kInfo, "info message");

161 log.AddEntry(Log::kError, "first error message");	164 log.AddEntry(Log::kError, "first error message");

162 log.AddEntry(Log::kDebug, "debug message");	165 log.AddEntry(Log::kDebug, "debug message");

163 log.AddEntry(Log::kError, "second error message");	166 log.AddEntry(Log::kError, "second error message");

164	167

165 entry = log.GetFirstErrorMessage();	168 entry = log.GetFirstErrorMessage();

166 ASSERT_EQ("first error message", entry);	169 ASSERT_EQ("first error message", entry);

167 }	170 }

OLD	NEW