chrome/renderer/safe_browsing/features_unittest.cc - Issue 1548153002: Switch to standard integer types in chrome/.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/renderer/safe_browsing/features_unittest.cc

Issue 1548153002: Switch to standard integer types in chrome/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/renderer/safe_browsing/features.h ('k') | chrome/renderer/safe_browsing/mock_feature_extractor_clock.h » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/renderer/safe_browsing/features.h"	5 #include "chrome/renderer/safe_browsing/features.h"

6	6

	7 #include <stddef.h>

	8

7 #include "base/format_macros.h"	9 #include "base/format_macros.h"

8 #include "base/strings/stringprintf.h"	10 #include "base/strings/stringprintf.h"

9 #include "chrome/renderer/safe_browsing/test_utils.h"	11 #include "chrome/renderer/safe_browsing/test_utils.h"

10 #include "testing/gtest/include/gtest/gtest.h"	12 #include "testing/gtest/include/gtest/gtest.h"

11	13

12 namespace safe_browsing {	14 namespace safe_browsing {

13	15

14 TEST(PhishingFeaturesTest, TooManyFeatures) {	16 TEST(PhishingFeaturesTest, TooManyFeatures) {

15 FeatureMap features;	17 FeatureMap features;

16 for (size_t i = 0; i < FeatureMap::kMaxFeatureMapSize; ++i) {	18 for (size_t i = 0; i < FeatureMap::kMaxFeatureMapSize; ++i) {

(...skipping 19 matching lines...) Expand all Loading...
36 EXPECT_FALSE(features.AddRealFeature("toolarge", 1.1));	38 EXPECT_FALSE(features.AddRealFeature("toolarge", 1.1));

37	39

38 FeatureMap expected_features;	40 FeatureMap expected_features;

39 expected_features.AddRealFeature("zero", 0.0);	41 expected_features.AddRealFeature("zero", 0.0);

40 expected_features.AddRealFeature("pointfive", 0.5);	42 expected_features.AddRealFeature("pointfive", 0.5);

41 expected_features.AddRealFeature("one", 1.0);	43 expected_features.AddRealFeature("one", 1.0);

42 ExpectFeatureMapsAreEqual(features, expected_features);	44 ExpectFeatureMapsAreEqual(features, expected_features);

43 }	45 }

44	46

45 } // namespace safe_browsing	47 } // namespace safe_browsing

OLD	NEW