Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(756)

Side by Side Diff: chrome/installer/util/logging_installer_unittest.cc

Issue 1548153002: Switch to standard integer types in chrome/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/installer/util/logging_installer.cc ('k') | chrome/installer/util/lzma_file_allocator.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stdint.h>
6
5 #include <string> 7 #include <string>
6 8
7 #include "base/files/file.h" 9 #include "base/files/file.h"
8 #include "base/files/file_path.h" 10 #include "base/files/file_path.h"
9 #include "base/files/file_util.h" 11 #include "base/files/file_util.h"
10 #include "base/files/scoped_temp_dir.h" 12 #include "base/files/scoped_temp_dir.h"
11 #include "base/win/scoped_handle.h" 13 #include "base/win/scoped_handle.h"
12 #include "chrome/installer/util/logging_installer.h" 14 #include "chrome/installer/util/logging_installer.h"
13 #include "testing/gtest/include/gtest/gtest.h" 15 #include "testing/gtest/include/gtest/gtest.h"
14 16
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
70 base::FilePath temp_file = temp_dir.path().Append(L"temp"); 72 base::FilePath temp_file = temp_dir.path().Append(L"temp");
71 EXPECT_EQ(static_cast<int>(test_data.size()), 73 EXPECT_EQ(static_cast<int>(test_data.size()),
72 base::WriteFile(temp_file, &test_data[0], 74 base::WriteFile(temp_file, &test_data[0],
73 static_cast<int>(test_data.size()))); 75 static_cast<int>(test_data.size())));
74 ASSERT_TRUE(base::PathExists(temp_file)); 76 ASSERT_TRUE(base::PathExists(temp_file));
75 int64_t file_size = 0; 77 int64_t file_size = 0;
76 EXPECT_TRUE(base::GetFileSize(temp_file, &file_size)); 78 EXPECT_TRUE(base::GetFileSize(temp_file, &file_size));
77 EXPECT_EQ(static_cast<int64_t>(test_data.size()), file_size); 79 EXPECT_EQ(static_cast<int64_t>(test_data.size()), file_size);
78 80
79 // Prevent the log file from being moved or deleted. 81 // Prevent the log file from being moved or deleted.
80 uint32 file_flags = base::File::FLAG_OPEN | 82 uint32_t file_flags = base::File::FLAG_OPEN | base::File::FLAG_READ |
81 base::File::FLAG_READ | 83 base::File::FLAG_EXCLUSIVE_READ;
82 base::File::FLAG_EXCLUSIVE_READ;
83 base::File temp_platform_file(temp_file, file_flags); 84 base::File temp_platform_file(temp_file, file_flags);
84 ASSERT_TRUE(temp_platform_file.IsValid()); 85 ASSERT_TRUE(temp_platform_file.IsValid());
85 86
86 EXPECT_EQ(installer::LOGFILE_UNTOUCHED, 87 EXPECT_EQ(installer::LOGFILE_UNTOUCHED,
87 installer::TruncateLogFileIfNeeded(temp_file)); 88 installer::TruncateLogFileIfNeeded(temp_file));
88 EXPECT_TRUE(base::PathExists(temp_file)); 89 EXPECT_TRUE(base::PathExists(temp_file));
89 EXPECT_TRUE(base::GetFileSize(temp_file, &file_size)); 90 EXPECT_TRUE(base::GetFileSize(temp_file, &file_size));
90 EXPECT_EQ(static_cast<int64_t>(test_data.size()), file_size); 91 EXPECT_EQ(static_cast<int64_t>(test_data.size()), file_size);
91 } 92 }
92 93
93 TEST(LoggingInstallerTest, TestMoveFailsNeedsTruncation) { 94 TEST(LoggingInstallerTest, TestMoveFailsNeedsTruncation) {
94 const std::string test_data(installer::kMaxInstallerLogFileSize + 1, 'a'); 95 const std::string test_data(installer::kMaxInstallerLogFileSize + 1, 'a');
95 96
96 base::ScopedTempDir temp_dir; 97 base::ScopedTempDir temp_dir;
97 ASSERT_TRUE(temp_dir.CreateUniqueTempDir()); 98 ASSERT_TRUE(temp_dir.CreateUniqueTempDir());
98 99
99 base::FilePath temp_file = temp_dir.path().Append(L"temp"); 100 base::FilePath temp_file = temp_dir.path().Append(L"temp");
100 EXPECT_EQ(static_cast<int>(test_data.size()), 101 EXPECT_EQ(static_cast<int>(test_data.size()),
101 base::WriteFile(temp_file, &test_data[0], 102 base::WriteFile(temp_file, &test_data[0],
102 static_cast<int>(test_data.size()))); 103 static_cast<int>(test_data.size())));
103 ASSERT_TRUE(base::PathExists(temp_file)); 104 ASSERT_TRUE(base::PathExists(temp_file));
104 int64_t file_size = 0; 105 int64_t file_size = 0;
105 EXPECT_TRUE(base::GetFileSize(temp_file, &file_size)); 106 EXPECT_TRUE(base::GetFileSize(temp_file, &file_size));
106 EXPECT_EQ(static_cast<int64_t>(test_data.size()), file_size); 107 EXPECT_EQ(static_cast<int64_t>(test_data.size()), file_size);
107 108
108 // Create an inconvenient, non-deletable file in the location that 109 // Create an inconvenient, non-deletable file in the location that
109 // TruncateLogFileIfNeeded would like to move the log file to. 110 // TruncateLogFileIfNeeded would like to move the log file to.
110 uint32 file_flags = base::File::FLAG_CREATE | 111 uint32_t file_flags = base::File::FLAG_CREATE | base::File::FLAG_READ |
111 base::File::FLAG_READ | 112 base::File::FLAG_EXCLUSIVE_READ;
112 base::File::FLAG_EXCLUSIVE_READ;
113 base::FilePath temp_file_move_dest( 113 base::FilePath temp_file_move_dest(
114 temp_file.value() + FILE_PATH_LITERAL(".tmp")); 114 temp_file.value() + FILE_PATH_LITERAL(".tmp"));
115 base::File temp_move_destination_file(temp_file_move_dest, file_flags); 115 base::File temp_move_destination_file(temp_file_move_dest, file_flags);
116 ASSERT_TRUE(temp_move_destination_file.IsValid()); 116 ASSERT_TRUE(temp_move_destination_file.IsValid());
117 117
118 EXPECT_EQ(installer::LOGFILE_DELETED, 118 EXPECT_EQ(installer::LOGFILE_DELETED,
119 installer::TruncateLogFileIfNeeded(temp_file)); 119 installer::TruncateLogFileIfNeeded(temp_file));
120 EXPECT_FALSE(base::PathExists(temp_file)); 120 EXPECT_FALSE(base::PathExists(temp_file));
121 } 121 }
OLDNEW
« no previous file with comments | « chrome/installer/util/logging_installer.cc ('k') | chrome/installer/util/lzma_file_allocator.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698