chrome/common/extensions/manifest_tests/extension_manifests_homepage_unittest.cc - Issue 1548153002: Switch to standard integer types in chrome/.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/common/extensions/manifest_tests/extension_manifests_homepage_unittest.cc

Issue 1548153002: Switch to standard integer types in chrome/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/common/extensions/manifest_tests/extension_manifests_contentsecuritypolicy_unittest.cc ('k') | chrome/common/extensions/manifest_tests/extension_manifests_initvalue_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

	5 #include "base/macros.h"

5 #include "base/strings/string_util.h"	6 #include "base/strings/string_util.h"

6 #include "chrome/common/extensions/manifest_tests/chrome_manifest_test.h"	7 #include "chrome/common/extensions/manifest_tests/chrome_manifest_test.h"

7 #include "extensions/common/extension.h"	8 #include "extensions/common/extension.h"

8 #include "extensions/common/manifest_constants.h"	9 #include "extensions/common/manifest_constants.h"

9 #include "extensions/common/manifest_url_handlers.h"	10 #include "extensions/common/manifest_url_handlers.h"

10 #include "testing/gtest/include/gtest/gtest.h"	11 #include "testing/gtest/include/gtest/gtest.h"

11	12

12 namespace errors = extensions::manifest_errors;	13 namespace errors = extensions::manifest_errors;

13	14

14 class HomepageURLManifestTest : public ChromeManifestTest {	15 class HomepageURLManifestTest : public ChromeManifestTest {

(...skipping 25 matching lines...) Expand all Loading...
40 // can be different in testing, so we just check the part before id.	41 // can be different in testing, so we just check the part before id.

41 extension = LoadAndExpectSuccess("homepage_google_hosted.json");	42 extension = LoadAndExpectSuccess("homepage_google_hosted.json");

42 EXPECT_TRUE(base::StartsWith(	43 EXPECT_TRUE(base::StartsWith(

43 extensions::ManifestURL::GetHomepageURL(extension.get()).spec(),	44 extensions::ManifestURL::GetHomepageURL(extension.get()).spec(),

44 "https://chrome.google.com/webstore/detail/",	45 "https://chrome.google.com/webstore/detail/",

45 base::CompareCase::INSENSITIVE_ASCII));	46 base::CompareCase::INSENSITIVE_ASCII));

46	47

47 extension = LoadAndExpectSuccess("homepage_externally_hosted.json");	48 extension = LoadAndExpectSuccess("homepage_externally_hosted.json");

48 EXPECT_EQ(GURL(), extensions::ManifestURL::GetHomepageURL(extension.get()));	49 EXPECT_EQ(GURL(), extensions::ManifestURL::GetHomepageURL(extension.get()));

49 }	50 }

OLD	NEW