chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.cc - Issue 1548133002: Switch to standard integer types in chrome/browser/, part 3 of 4.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.cc

Issue 1548133002: Switch to standard integer types in chrome/browser/, part 3 of 4. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/incident_reporting/extension_data_collection_unittest.cc ('k') | chrome/browser/safe_browsing/incident_reporting/incident_reporting_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.cc

diff --git a/chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.cc b/chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.cc

index 5f9ebab9731a9f97c0d80e98358694de55a42cbd..82e9d5ceff8d398d986d4a5814a9bd68720aa24d 100644

--- a/chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.cc

+++ b/chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.cc

@@ -5,10 +5,12 @@

#include "chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.h"

#include <math.h>

+#include <stddef.h>

#include <algorithm>

#include <vector>

+#include "base/macros.h"

#include "base/metrics/field_trial.h"

#include "base/metrics/histogram.h"

#include "base/prefs/pref_service.h"

@@ -18,6 +20,7 @@

#include "base/strings/string_util.h"

#include "base/thread_task_runner_handle.h"

#include "base/threading/sequenced_worker_pool.h"

+#include "build/build_config.h"

#include "chrome/browser/chrome_notification_types.h"

#include "chrome/browser/metrics/chrome_metrics_service_accessor.h"

#include "chrome/browser/profiles/profile.h"

@@ -67,10 +70,10 @@ struct PersistentIncidentState {

};

// The amount of time the service will wait to collate incidents.

-const int64 kDefaultUploadDelayMs = 1000 * 60; // one minute

+const int64_t kDefaultUploadDelayMs = 1000 * 60; // one minute

// The amount of time between running delayed analysis callbacks.

-const int64 kDefaultCallbackIntervalMs = 1000 * 20;

+const int64_t kDefaultCallbackIntervalMs = 1000 * 20;

// Logs the type of incident in |incident_data| to a user metrics histogram.

void LogIncidentDataType(IncidentDisposition disposition,