components/metrics/serialization/serialization_utils.cc - Issue 1548113002: Switch to standard integer types in components/, part 2 of 4.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/metrics/serialization/serialization_utils.cc

Issue 1548113002: Switch to standard integer types in components/, part 2 of 4. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: gn Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/metrics/profiler/tracking_synchronizer_unittest.cc ('k') | components/metrics/serialization/serialization_utils_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/metrics/serialization/serialization_utils.cc

diff --git a/components/metrics/serialization/serialization_utils.cc b/components/metrics/serialization/serialization_utils.cc

index 4c4be8c4d426bb77bc980a984b10400d9b82254a..97a6e0fb4db7da32180e85a5e02d9d552f28ebab 100644

--- a/components/metrics/serialization/serialization_utils.cc

+++ b/components/metrics/serialization/serialization_utils.cc

@@ -5,6 +5,7 @@

#include "components/metrics/serialization/serialization_utils.h"

#include <errno.h>

+#include <stdint.h>

#include <sys/file.h>

#include <string>

@@ -196,7 +197,7 @@ bool SerializationUtils::WriteMetricToFile(const MetricSample& sample,

}

std::string msg = sample.ToString();

- int32 size = msg.length() + sizeof(int32);

+ int32_t size = msg.length() + sizeof(int32_t);

if (size > kMessageMaxLength) {

DPLOG(ERROR) << "cannot write message: too long: " << filename;

return false;