components/metrics/metrics_service_client.h - Issue 1548113002: Switch to standard integer types in components/, part 2 of 4.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/metrics/metrics_service_client.h

Issue 1548113002: Switch to standard integer types in components/, part 2 of 4. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: gn Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/metrics/metrics_service_client.h

diff --git a/components/metrics/metrics_service_client.h b/components/metrics/metrics_service_client.h

index 93b7300e0b49a323dbad354530a78768c04c5f0d..1542db093564ad2c24a7b898d667521f0d92f16e 100644

--- a/components/metrics/metrics_service_client.h

+++ b/components/metrics/metrics_service_client.h

@@ -8,7 +8,6 @@

#include <stdint.h>

#include <string>

-#include "base/basictypes.h"

#include "base/callback_forward.h"

#include "base/memory/scoped_ptr.h"

#include "base/strings/string16.h"

@@ -49,7 +48,7 @@ class MetricsServiceClient {

// Returns the product value to use in uploaded reports, which will be used to

// set the ChromeUserMetricsExtension.product field. See comments on that

- // field on why it's an int32 rather than an enum.

+ // field on why it's an int32_t rather than an enum.

virtual int32_t GetProduct() = 0;

// Returns the current application locale (e.g. "en-US").

« no previous file with comments | « components/metrics/metrics_service.cc ('k') | components/metrics/metrics_service_unittest.cc » ('j') | no next file with comments »