Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Issue 154803002: Use ContainerNode type instead of Node for LiveNodeListBase's rootNode (Closed)

Created:
6 years, 10 months ago by Inactive
Modified:
6 years, 10 months ago
Reviewers:
esprehn, adamk
CC:
blink-reviews, dglazkov+blink, adamk+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Use ContainerNode type instead of Node for LiveNodeListBase's rootNode Use ContainerNode type instead of Node for LiveNodeListBase's rootNode. LiveNodeListBase::rootNode() returns a ContainerNode but this was sometimes assigned to a Node was we would loose the type information. This is particularly useful because some methods are faster on ContainerNode than Node, e.g. lastNode(). This CL updates both lastNode() and lastDescendant() methods in HTMLCollection.cpp, both of which can now call ContainerNode::lastNode() instead of the slower Node::lastNode(). R=esprehn, adamk Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166512

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M Source/core/html/HTMLCollection.cpp View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
Inactive
6 years, 10 months ago (2014-02-04 23:31:12 UTC) #1
adamk
lgtm
6 years, 10 months ago (2014-02-04 23:54:46 UTC) #2
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 10 months ago (2014-02-05 00:03:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/154803002/1
6 years, 10 months ago (2014-02-05 00:03:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/154803002/1
6 years, 10 months ago (2014-02-05 00:40:54 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-05 01:26:57 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) blink_heap_unittests, blink_platform_unittests, webkit_lint, webkit_python_tests, webkit_tests, webkit_unit_tests, ...
6 years, 10 months ago (2014-02-05 01:26:57 UTC) #7
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 10 months ago (2014-02-05 01:35:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/154803002/1
6 years, 10 months ago (2014-02-05 01:36:07 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-05 04:51:55 UTC) #10
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=25707
6 years, 10 months ago (2014-02-05 04:51:56 UTC) #11
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 10 months ago (2014-02-05 13:23:31 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/154803002/1
6 years, 10 months ago (2014-02-05 13:23:38 UTC) #13
commit-bot: I haz the power
6 years, 10 months ago (2014-02-05 16:27:58 UTC) #14
Message was sent while issue was closed.
Change committed as 166512

Powered by Google App Engine
This is Rietveld 408576698