Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Issue 1548023002: Clear memory of broker related structs sent over the new Mojo EDK. (Closed)

Created:
5 years ago by jam
Modified:
4 years, 12 months ago
Reviewers:
yzshen1
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clear memory of broker related structs sent over the new Mojo EDK. Padding bytes weren't initialized which was causing dr memory errors. BUG=561803 TBR=yzshen@chromium.org Committed: https://crrev.com/5b80cc34ca7e056ae2579ef5c5d859d50aaf559b Cr-Commit-Position: refs/heads/master@{#366795}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M mojo/edk/system/child_broker.cc View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/edk/system/child_broker_host.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
jam
5 years ago (2015-12-24 02:24:06 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1548023002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1548023002/1
5 years ago (2015-12-24 02:24:20 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 12 months ago (2015-12-24 03:35:45 UTC) #4
commit-bot: I haz the power
4 years, 12 months ago (2015-12-24 03:36:48 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5b80cc34ca7e056ae2579ef5c5d859d50aaf559b
Cr-Commit-Position: refs/heads/master@{#366795}

Powered by Google App Engine
This is Rietveld 408576698