Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Unified Diff: gpu/GLES2/extensions/CHROMIUM/CHROMIUM_copy_texture.txt

Issue 1547873002: Allow GL_TEXTURE_RECTANGLE_ARB to be the destination target for copyTextureCHROMIUM. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix shader compile error. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/GLES2/extensions/CHROMIUM/CHROMIUM_copy_texture.txt
diff --git a/gpu/GLES2/extensions/CHROMIUM/CHROMIUM_copy_texture.txt b/gpu/GLES2/extensions/CHROMIUM/CHROMIUM_copy_texture.txt
index 101c0f6491d16f4d01d8d7c79b2e39942ea021cc..559685f4c0b6ed92fceffdaa35143a7123f1ffa9 100644
--- a/gpu/GLES2/extensions/CHROMIUM/CHROMIUM_copy_texture.txt
+++ b/gpu/GLES2/extensions/CHROMIUM/CHROMIUM_copy_texture.txt
@@ -40,9 +40,7 @@ New Procedures and Functions
GLboolean unpack_premultiply_alpha,
GLboolean unpack_unmultiply_alpha)
- Copies the contents of texture referred to by <source_id> to <dest_id>
- texture. If <source_id> texture is not defined or has different dimension
- to <dest_id> texture, define <source_id> texture same to <dest_id> texture.
+ Copies the contents of <source_id> texture to <dest_id> texture.
Texture level 0 is copied from the source image to level 0 of the
destination texture.
@@ -84,13 +82,14 @@ New Procedures and Functions
INVALID_OPERATION is generated if the internal format of <source_id> is not one of
formats from the table above.
- INVALID_VALUE is generated if <target> is not GL_TEXTURE_2D.
+ INVALID_VALUE is generated if <target> is not GL_TEXTURE_2D or
+ GL_TEXTURE_RECTANGLE_ARB.
INVALID_VALUE is generated if <source_id> or <dest_id> are not valid texture
objects.
INVALID_VALUE is generated if textures corresponding to <dest_id> have not
- been bound as GL_TEXTURE_2D object.
+ been bound as GL_TEXTURE_2D or GL_TEXTURE_RECTANGLE_ARB object.
INVALID_VALUE is generated if textures corresponding to <source_id> have not
been bound as GL_TEXTURE_2D, GL_TEXTURE_RECTANGLE_ARB or
@@ -125,14 +124,21 @@ New Procedures and Functions
<height> specifies the width of the texture subimage.
+ INVALID_VALUE is generated if either <source_id> texture or <dest_id>
+ texture is not defined.
+
INVALID_OPERATION is generated if source internal_format and destination
internal_format are not one of the valid formats described above.
- INVALID_VALUE is generated if <target> is not GL_TEXTURE_2D.
+ INVALID_VALUE is generated if <target> is not GL_TEXTURE_2D or
+ GL_TEXTURE_RECTANGLE_ARB.
INVALID_OPERATION is generated if the destination texture has not been
defined.
+ INVALID_VALUE is generated if <dest_id> texture is not bound as
+ GL_TEXTURE_2D or GL_TEXTURE_RECTANGLE_ARB.
+
INVALID_VALUE is generated if level 0 of the source texture or
the destination texture is not defined.
@@ -170,3 +176,4 @@ Revision History
16/7/2014 Add GL_TEXTURE_RECTANGLE_ARB as valid source_id target
19/6/2015 Add arguments unpack_flip_y, unpack_premultiply_alpha, and
unpack_unmultiply_alpha to both commands.
+ 22/12/2015 Add GL_TEXTURE_RECTANGLE_ARB as valid dest_id target

Powered by Google App Engine
This is Rietveld 408576698