Issue 1547843003: Merge to XFA: Cleanup: Remove some dead code in CPWL_Note.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1547843003: Merge to XFA: Cleanup: Remove some dead code in CPWL_Note. (Closed)

Created:
5 years ago by Lei Zhang

Modified:
5 years ago

Reviewers:
Oliver Chang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Merge to XFA: Cleanup: Remove some dead code in CPWL_Note. TBR=ochang@chromium.org Review URL: https://codereview.chromium.org/1544953002 . (cherry picked from commit cd0ade6f77b1a3e7c340a05bc6cb448f52e9bb96) Committed: https://pdfium.googlesource.com/pdfium/+/ae6c84307e7db98564617fb90221ab339f4ca3f1

Created: 5 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -52 lines)			Patch
	M	fpdfsdk/include/pdfwindow/PWL_Note.h	View		2 chunks	+1 line, -9 lines	0 comments	Download
	M	fpdfsdk/src/pdfwindow/PWL_Note.cpp	View		4 chunks	+3 lines, -43 lines	0 comments	Download

Total messages: 4 (1 generated)

Lei Zhang

TBR The mac bot is broken even after a clobber. Let's see what happens on ...

5 years ago (2015-12-23 01:20:19 UTC) #1

Lei Zhang

Committed patchset #1 (id:1) manually as ae6c84307e7db98564617fb90221ab339f4ca3f1 (tree was closed).

5 years ago (2015-12-23 01:20:39 UTC) #3

Message was sent while issue was closed.

lgtm