core/src/fpdfapi/fpdf_parser/fpdf_parser_parser_unittest.cpp - Issue 1547833002: Switch from nonstd::unique_ptr to std::unique_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fpdfapi/fpdf_parser/fpdf_parser_parser_unittest.cpp

Issue 1547833002: Switch from nonstd::unique_ptr to std::unique_ptr. (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master

Patch Set: rebase Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fpdfapi/fpdf_parser/fpdf_parser_parser_unittest.cpp

diff --git a/core/src/fpdfapi/fpdf_parser/fpdf_parser_parser_unittest.cpp b/core/src/fpdfapi/fpdf_parser/fpdf_parser_parser_unittest.cpp

index 3fd8dcf35a600fc1ac533dc6d60e0a08b3f73baa..3014ca280ed54bd1e7c66e559bd0c2195eac46e3 100644

--- a/core/src/fpdfapi/fpdf_parser/fpdf_parser_parser_unittest.cpp

+++ b/core/src/fpdfapi/fpdf_parser/fpdf_parser_parser_unittest.cpp

@@ -97,7 +97,7 @@ class CPDF_TestParser : public CPDF_Parser {

// TODO(thestig) Using unique_ptr with ReleaseDeleter is still not ideal.

// Come up or wait for something better.

using ScopedFileStream =

- nonstd::unique_ptr<IFX_FileStream, ReleaseDeleter<IFX_FileStream>>;

+ std::unique_ptr<IFX_FileStream, ReleaseDeleter<IFX_FileStream>>;

TEST(fpdf_parser_parser, ReadHexString) {

{