ui/views/widget/desktop_aura/desktop_window_tree_host_win.cc - Issue 154783002: Honor can_activate flag in ShowWindowWithState

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/widget/desktop_aura/desktop_window_tree_host_win.cc

Issue 154783002: Honor can_activate flag in ShowWindowWithState (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: More review comments Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/widget/desktop_aura/desktop_window_tree_host_win.cc

diff --git a/ui/views/widget/desktop_aura/desktop_window_tree_host_win.cc b/ui/views/widget/desktop_aura/desktop_window_tree_host_win.cc

index 6e71f05a8b00c5c10494665af35a63ad965c3f7d..9f453e52a546ff403c839a1cc10369853aeb2ba0 100644

--- a/ui/views/widget/desktop_aura/desktop_window_tree_host_win.cc

+++ b/ui/views/widget/desktop_aura/desktop_window_tree_host_win.cc

@@ -611,7 +611,7 @@ bool DesktopWindowTreeHostWin::IsModal() const {

}

int DesktopWindowTreeHostWin::GetInitialShowState() const {

- return SW_SHOWNORMAL;

+ return CanActivate() ? SW_SHOWNORMAL : SW_SHOWNOACTIVATE;

}

bool DesktopWindowTreeHostWin::WillProcessWorkAreaChange() const {