Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: ui/views/widget/widget.cc

Issue 154783002: Honor can_activate flag in ShowWindowWithState (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« ui/views/touchui/touch_selection_controller_impl.h ('K') | « ui/views/widget/desktop_aura/desktop_window_tree_host_win.cc ('k') | ui/views/widget/widget_interactive_uitest.cc » ('j') | ui/views/widget/widget_interactive_uitest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/widget/widget.cc
diff --git a/ui/views/widget/widget.cc b/ui/views/widget/widget.cc
index d773f1fef801553c975d07fc9586e520a4b93a5e..472e2976b1d2ef07e444d8808b2bf990887eae30 100644
--- a/ui/views/widget/widget.cc
+++ b/ui/views/widget/widget.cc
@@ -71,7 +71,7 @@ class DefaultWidgetDelegate : public WidgetDelegate {
public:
DefaultWidgetDelegate(Widget* widget, const Widget::InitParams& params)
: widget_(widget),
- can_activate_(!params.child &&
+ can_activate_(params.can_activate && !params.child &&
sky 2014/05/15 16:44:01 You need to sync with https://codereview.chromium.
mohsen 2014/05/16 15:56:09 Not needed anymore. Already handled in the above C
params.type != Widget::InitParams::TYPE_POPUP &&
params.type != Widget::InitParams::TYPE_DRAG) {
}
« ui/views/touchui/touch_selection_controller_impl.h ('K') | « ui/views/widget/desktop_aura/desktop_window_tree_host_win.cc ('k') | ui/views/widget/widget_interactive_uitest.cc » ('j') | ui/views/widget/widget_interactive_uitest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698