chromecast/browser/cast_browser_main_parts.cc - Issue 1547793004: Make gpu black list work again on Linux

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromecast/browser/cast_browser_main_parts.cc

Issue 1547793004: Make gpu black list work again on Linux (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Move for loop post_init_tasks_ from Initialize to InitializeImpl. And add a cc unit test. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromecast/browser/cast_browser_main_parts.cc

diff --git a/chromecast/browser/cast_browser_main_parts.cc b/chromecast/browser/cast_browser_main_parts.cc

index 8c29892c3514229b03d31414f50b81598ec160ef..2ee6edbdf5eb92681e7bb0b6071b9135c429ebb2 100644

--- a/chromecast/browser/cast_browser_main_parts.cc

+++ b/chromecast/browser/cast_browser_main_parts.cc

@@ -343,6 +343,9 @@ void CastBrowserMainParts::PreMainMessageLoopRun() {

// Set GL strings so GPU config code can make correct feature blacklisting/

// whitelisting decisions.

// Note: SetGLStrings MUST be called after GpuDataManager::Initialize.

+ // TODO(j.isorce) move SetGLStrings call to PreCreateThreads, i.e. before

+ // launching the gpu process since these infos are used to decide whether or

jam 2016/02/10 18:32:33 why is this a todo instead of actually doing it?

+ // not to spawn it.

scoped_ptr<CastSysInfo> sys_info = CreateSysInfo();

content::GpuDataManager::GetInstance()->SetGLStrings(

sys_info->GetGlVendor(), sys_info->GetGlRenderer(),