Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1225)

Unified Diff: chromecast/browser/cast_browser_main_parts.cc

Issue 1547793004: Make gpu black list work again on Linux (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove changes from gpu_info_collector files Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromecast/browser/cast_browser_main_parts.cc
diff --git a/chromecast/browser/cast_browser_main_parts.cc b/chromecast/browser/cast_browser_main_parts.cc
index e67b3d2342689b39b739796dabe066468e61cd33..ac89241a93d100e6a65ff70331d517a697b36433 100644
--- a/chromecast/browser/cast_browser_main_parts.cc
+++ b/chromecast/browser/cast_browser_main_parts.cc
@@ -299,7 +299,7 @@ void CastBrowserMainParts::ToolkitInitialized() {
#endif
}
-int CastBrowserMainParts::PreCreateThreads() {
+int CastBrowserMainParts::PreCreateThreadsBegin() {
#if defined(OS_ANDROID)
// GPU process is started immediately after threads are created, requiring
// CrashDumpManager to be initialized beforehand.
@@ -343,6 +343,8 @@ void CastBrowserMainParts::PreMainMessageLoopRun() {
// Set GL strings so GPU config code can make correct feature blacklisting/
// whitelisting decisions.
// Note: SetGLStrings MUST be called after GpuDataManager::Initialize.
+ // TODO(j.isorce) move SetGLStrings call to PreCreateThreadsEnd, i.e. before
+ // launching the gpu process.
scoped_ptr<CastSysInfo> sys_info = CreateSysInfo();
content::GpuDataManager::GetInstance()->SetGLStrings(
sys_info->GetGlVendor(), sys_info->GetGlRenderer(),

Powered by Google App Engine
This is Rietveld 408576698