Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1547683004: Switch to standard integer types in rlz/. (Closed)

Created:
5 years ago by Avi (use Gerrit)
Modified:
5 years ago
Reviewers:
Nico
CC:
chromium-reviews, gab+watch_chromium.org, robertshield+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch to standard integer types in rlz/. BUG=138542 TBR=thakis@chromium.org Committed: https://crrev.com/d41cf18d9d44f9a75de1b260779b23a9670dc664 Cr-Commit-Position: refs/heads/master@{#366614}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -51 lines) Patch
M rlz/chromeos/lib/rlz_value_store_chromeos.h View 2 chunks +6 lines, -2 lines 0 comments Download
M rlz/chromeos/lib/rlz_value_store_chromeos.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M rlz/lib/crc8_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M rlz/lib/financial_ping.cc View 5 chunks +10 lines, -7 lines 0 comments Download
M rlz/lib/financial_ping_test.cc View 7 chunks +14 lines, -12 lines 0 comments Download
M rlz/lib/lib_values.h View 2 chunks +4 lines, -3 lines 0 comments Download
M rlz/lib/lib_values.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M rlz/lib/machine_id.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M rlz/lib/rlz_lib.h View 1 chunk +1 line, -0 lines 0 comments Download
M rlz/lib/rlz_lib.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M rlz/lib/rlz_lib_test.cc View 1 chunk +4 lines, -1 line 0 comments Download
M rlz/lib/rlz_value_store.h View 3 chunks +9 lines, -7 lines 0 comments Download
M rlz/lib/string_utils_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M rlz/mac/lib/machine_id_mac.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M rlz/mac/lib/rlz_value_store_mac.h View 2 chunks +6 lines, -2 lines 0 comments Download
M rlz/mac/lib/rlz_value_store_mac.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M rlz/test/rlz_test_helpers.h View 1 chunk +1 line, -0 lines 0 comments Download
M rlz/test/rlz_test_helpers.cc View 3 chunks +6 lines, -2 lines 0 comments Download
M rlz/test/rlz_unittest_main.cc View 1 chunk +1 line, -0 lines 0 comments Download
M rlz/win/dll/exports.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M rlz/win/lib/machine_deal.cc View 1 chunk +2 lines, -1 line 0 comments Download
M rlz/win/lib/machine_id_win.cc View 1 chunk +1 line, -0 lines 0 comments Download
M rlz/win/lib/process_info.h View 1 chunk +1 line, -1 line 0 comments Download
M rlz/win/lib/process_info.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M rlz/win/lib/registry_util.h View 1 chunk +2 lines, -0 lines 0 comments Download
M rlz/win/lib/rlz_lib_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M rlz/win/lib/rlz_value_store_registry.h View 2 chunks +6 lines, -2 lines 0 comments Download
M rlz/win/lib/rlz_value_store_registry.cc View 4 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Avi (use Gerrit)
Please review.
5 years ago (2015-12-22 17:26:02 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1547683004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1547683004/1
5 years ago (2015-12-22 17:26:20 UTC) #3
Nico
lgtm
5 years ago (2015-12-22 17:33:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1547683004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1547683004/1
5 years ago (2015-12-22 17:34:47 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-22 18:06:20 UTC) #8
commit-bot: I haz the power
5 years ago (2015-12-22 18:07:28 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/d41cf18d9d44f9a75de1b260779b23a9670dc664
Cr-Commit-Position: refs/heads/master@{#366614}

Powered by Google App Engine
This is Rietveld 408576698