Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Unified Diff: lib/Driver/Driver.cpp

Issue 1547623002: Clang toolchain driver for PNaCl (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-clang.git@master
Patch Set: Review feedback addressed Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/Basic/Targets.cpp ('k') | lib/Driver/ToolChains.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/Driver/Driver.cpp
diff --git a/lib/Driver/Driver.cpp b/lib/Driver/Driver.cpp
index 07a5e42cb1397ec91fe46df3f7bc2ff830e78426..9dd557cf780a57a094be4a45d9febdd17d25193c 100644
--- a/lib/Driver/Driver.cpp
+++ b/lib/Driver/Driver.cpp
@@ -1161,7 +1161,8 @@ void Driver::BuildActions(const ToolChain &TC, DerivedArgList &Args,
Arg *FinalPhaseArg;
phases::ID FinalPhase = getFinalPhase(Args, &FinalPhaseArg);
- if (FinalPhase == phases::Link && Args.hasArg(options::OPT_emit_llvm)) {
+ if (FinalPhase == phases::Link && Args.hasArg(options::OPT_emit_llvm) &&
+ !TC.isBitcodeOnlyTarget()) {
Diag(clang::diag::err_drv_emit_llvm_link);
}
@@ -1266,6 +1267,10 @@ void Driver::BuildActions(const ToolChain &TC, DerivedArgList &Args,
break;
}
+ // Virtual targets don't perform assembly step.
+ if (Phase == phases::Assemble && TC.isBitcodeOnlyTarget())
+ continue;
+
// Some types skip the assembler phase (e.g., llvm-bc), but we can't
// encode this in the steps because the intermediate type depends on
// arguments. Just special case here.
@@ -1364,7 +1369,7 @@ Driver::ConstructPhaseAction(const ToolChain &TC, const ArgList &Args,
Args.hasArg(options::OPT_S) ? types::TY_LTO_IR : types::TY_LTO_BC;
return llvm::make_unique<BackendJobAction>(std::move(Input), Output);
}
- if (Args.hasArg(options::OPT_emit_llvm)) {
+ if (Args.hasArg(options::OPT_emit_llvm) || TC.isBitcodeOnlyTarget()) {
types::ID Output =
Args.hasArg(options::OPT_S) ? types::TY_LLVM_IR : types::TY_LLVM_BC;
return llvm::make_unique<BackendJobAction>(std::move(Input), Output);
@@ -2063,7 +2068,10 @@ const ToolChain &Driver::getToolChain(const ArgList &Args,
TC = new toolchains::Linux(*this, Target, Args);
break;
case llvm::Triple::NaCl:
- TC = new toolchains::NaCl_TC(*this, Target, Args);
+ if (Target.getArch() == llvm::Triple::le32)
+ TC = new toolchains::PNaClToolChain(*this, Target, Args);
+ else
+ TC = new toolchains::NaCl_TC(*this, Target, Args);
break;
case llvm::Triple::Solaris:
TC = new toolchains::Solaris(*this, Target, Args);
« no previous file with comments | « lib/Basic/Targets.cpp ('k') | lib/Driver/ToolChains.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698