Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1440)

Unified Diff: content/browser/loader/resource_loader.cc

Issue 15476003: Move TransferNavigationResourceThrottle into CrossSiteResourceHandler. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Get tests to pass Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/loader/resource_loader.cc
diff --git a/content/browser/loader/resource_loader.cc b/content/browser/loader/resource_loader.cc
index df4bf48e98ad40f71b09c7ea19e53bacc79dd47e..39cc6aab2889b3479fa7cad4622927a810f5e265 100644
--- a/content/browser/loader/resource_loader.cc
+++ b/content/browser/loader/resource_loader.cc
@@ -172,12 +172,11 @@ void ResourceLoader::WillCompleteTransfer() {
}
void ResourceLoader::CompleteTransfer(scoped_ptr<ResourceHandler> new_handler) {
- DCHECK_EQ(DEFERRED_REDIRECT, deferred_stage_);
+ DCHECK_EQ(DEFERRED_READ, deferred_stage_);
DCHECK(!handler_.get());
handler_ = new_handler.Pass();
handler_->SetController(this);
- is_transferring_ = false;
Resume();
}
@@ -426,7 +425,8 @@ void ResourceLoader::ContinueSSLRequest(const GlobalRequestID& id) {
}
void ResourceLoader::Resume() {
- DCHECK(!is_transferring_);
+ bool was_transfer = is_transferring_;
+ is_transferring_ = false;
DeferredStage stage = deferred_stage_;
deferred_stage_ = DEFERRED_NONE;
@@ -441,10 +441,16 @@ void ResourceLoader::Resume() {
request_->FollowDeferredRedirect();
break;
case DEFERRED_READ:
- base::MessageLoop::current()->PostTask(
- FROM_HERE,
- base::Bind(&ResourceLoader::ResumeReading,
- weak_ptr_factory_.GetWeakPtr()));
+ if (was_transfer) {
+ // We need to go through the OnResponseStarted steps again in the new
+ // resource handler.
+ OnResponseStarted(request_.get());
+ } else {
+ base::MessageLoop::current()->PostTask(
+ FROM_HERE,
+ base::Bind(&ResourceLoader::ResumeReading,
+ weak_ptr_factory_.GetWeakPtr()));
+ }
break;
case DEFERRED_FINISH:
// Delay self-destruction since we don't know how we were reached.

Powered by Google App Engine
This is Rietveld 408576698