Move TransferNavigationResourceThrottle into CrossSiteResourceHandler.

content/browser/loader/resource_dispatcher_host_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <vector>
 
 #include "base/bind.h"
 #include "base/files/file_path.h"
 #include "base/memory/scoped_vector.h"
 #include "base/message_loop.h"
@@ skipping 1685 matching lines @@
 
   // Cancelling by other methods shouldn't work either.
   host_.CancelRequestsForProcess(render_view_id);
   EXPECT_EQ(1, host_.pending_requests());
 
   // Cancelling by context should work.
   host_.CancelRequestsForContext(filter_->resource_context());
   EXPECT_EQ(0, host_.pending_requests());
 }
 
+// TODO(creis): How can we get this to pass?
 TEST_F(ResourceDispatcherHostTest, TransferNavigation) {
   EXPECT_EQ(0, host_.pending_requests());
 
   int render_view_id = 0;
   int request_id = 1;
 
   // Configure initial request.
   SetResponse("HTTP/1.1 302 Found\n"
               "Location: http://other.com/blech\n\n");
 
@@ skipping 27 matching lines @@
                             GURL("http://other.com/blech"));
   request.transferred_request_child_id = filter_->child_id();
   request.transferred_request_request_id = request_id;
 
   // For cleanup.
   child_ids_.insert(second_filter->child_id());
   ResourceHostMsg_RequestResource transfer_request_msg(
       new_render_view_id, new_request_id, request);
   bool msg_was_ok;
   host_.OnMessageReceived(
       transfer_request_msg, second_filter.get(), &msg_was_ok);

[Matt Perry, 2013/06/18 22:58:51]

Why doesn't this result in another OnResponseStarted? This is where
ResourceDispatcherHost::BeginRequest gets called. I'd expect that to start the
new request.

[Charlie Reis, 2013/06/19 00:17:01]

We do get to BeginRequest in this call, but the deferred loader isn't marked as
transferring.  (it->second->is_transferring() is false, so we kill the renderer
with BadMessageReceived.)

It's not marked as transferring because we never get to CSRH::OnResponseStarted
(or even ResourceLoader::OnResponseStarted) at any point during the test.

Somehow we need to make the http://other.com/blech request get to
OnResponseStarted to set up the transfer, but I haven't been able to figure out
how to do that.

[Matt Perry, 2013/06/19 00:28:42]

Looks like ResourceDispatcherHostTest::Factory is what actually creates the
URLRequestJob for the request. Find out which test job is being created, and
make sure that guy calls URLRequest::NotifyHeadersComplete. I think...

[Charlie Reis, 2013/06/19 01:09:24]

Making progress!  It's a URLRequestTestJob, and we do get to
URLRequest::NotifyHeadersComplete.  That sees IsRedirectResponse return true,
though, so it calls SetBlockedOnDelegate() and returns early rather than getting
to the request_->NotifyResponseStarted() line.

I'm thinking we could move the SetResponse call a little higher (just below the
MakeTestRequest call), and then do something to unblock the URLRequest so it
starts reading the response?  Can we do that?  (Just calling MakeTestRequest
again doesn't work, since it creates a whole new request and hits the same crash
as before.)

[Matt Perry, 2013/06/19 01:20:56]

Not sure how to unblock. I'm assuming ResourceLoader is the URLRequest::Delegate
in this case? It has a ResourceLoader::Resume() method which seems to undo the
defer that happens in ResourceLoader::OnReceivedRedirect.

   base::MessageLoop::current()->RunUntilIdle();
 
   // Flush all the pending requests.
   while (net::URLRequestTestJob::ProcessOnePendingMessage()) {}
 
   // Check generated messages.
   ResourceIPCAccumulator::ClassifiedMessages msgs;
   accum_.GetClassifiedMessages(&msgs);
 
   ASSERT_EQ(1U, msgs.size());
   CheckSuccessfulRequest(msgs[0], kResponseBody);
 }
 
+// TODO(creis): How can we get this to pass?
 TEST_F(ResourceDispatcherHostTest, TransferNavigationAndThenRedirect) {
   EXPECT_EQ(0, host_.pending_requests());
 
   int render_view_id = 0;
   int request_id = 1;
 
   // Configure initial request.
   SetResponse("HTTP/1.1 302 Found\n"
               "Location: http://other.com/blech\n\n");
 
@@ skipping 221 matching lines @@
     }
 
     base::MessageLoop::current()->RunUntilIdle();
 
     msgs.clear();
     accum_.GetClassifiedMessages(&msgs);
   }
 }
 
 }  // namespace content