Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Unified Diff: net/base/mime_util_unittest.cc

Issue 1547593002: Introducing a net::GenerateMimeMultipartBoundary helper. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Self-review. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« net/base/mime_util.cc ('K') | « net/base/mime_util.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/mime_util_unittest.cc
diff --git a/net/base/mime_util_unittest.cc b/net/base/mime_util_unittest.cc
index 8bc61bc8052854e78f9795737bf8e2ad0f613007..d45f9c4ab5bbb065329631aaa5d93e9154b62d53 100644
--- a/net/base/mime_util_unittest.cc
+++ b/net/base/mime_util_unittest.cc
@@ -273,6 +273,15 @@ TEST(MimeUtilTest, TestGetExtensionsForMimeType) {
}
}
+TEST(MimeUtilTest, TestGenerateMimeMultipartBoundary) {
+ std::string boundary1 = GenerateMimeMultipartBoundary();
+ std::string boundary2 = GenerateMimeMultipartBoundary();
+ EXPECT_GT(70u, boundary1.size());
+ EXPECT_GT(70u, boundary2.size());
+ EXPECT_TRUE(boundary1.find("MultipartBoundary") != std::string::npos);
+ EXPECT_TRUE(boundary2.find("MultipartBoundary") != std::string::npos);
Ryan Sleevi 2015/12/28 23:30:00 EXPECT_NE ?
Łukasz Anforowicz 2015/12/29 18:53:19 Done + also tweaked the other asserts, added a few
+ EXPECT_NE(boundary1, boundary2);
+}
TEST(MimeUtilTest, TestAddMultipartValueForUpload) {
const char ref_output[] =
« net/base/mime_util.cc ('K') | « net/base/mime_util.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698