cloud_print/gcp20/prototype/cloud_print_requester.cc - Issue 1547593002: Introducing a net::GenerateMimeMultipartBoundary helper.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cloud_print/gcp20/prototype/cloud_print_requester.cc

Issue 1547593002: Introducing a net::GenerateMimeMultipartBoundary helper. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Self-review. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/policy/upload_job_impl.cc ('K') | « chrome/service/cloud_print/printer_job_handler.cc ('k') | components/search_engines/template_url.cc » ('j') | google_apis/drive/base_requests.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: cloud_print/gcp20/prototype/cloud_print_requester.cc

diff --git a/cloud_print/gcp20/prototype/cloud_print_requester.cc b/cloud_print/gcp20/prototype/cloud_print_requester.cc

index 9b94a384fb69463a0d13316b47c6346aca3f9d07..d0510e9ef9eb5fd419bd799a194390cf12357ace 100644

--- a/cloud_print/gcp20/prototype/cloud_print_requester.cc

+++ b/cloud_print/gcp20/prototype/cloud_print_requester.cc

@@ -125,11 +125,7 @@ void CloudPrintRequester::StartRegistration(const std::string& proxy_id,

const std::string& user,

const LocalSettings& settings,

const std::string& cdd) {

- std::string mime_boundary;

- int r1 = base::RandInt(0, std::numeric_limits<int32_t>::max());

- int r2 = base::RandInt(0, std::numeric_limits<int32_t>::max());

- base::SStringPrintf(&mime_boundary,

- "---------------------------%08X%08X", r1, r2);

+ std::string mime_boundary = net::GenerateMimeMultipartBoundary();

std::string data;

std::string data_mimetype;