chrome/service/cloud_print/cloud_print_connector.cc - Issue 1547593002: Introducing a net::GenerateMimeMultipartBoundary helper.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/service/cloud_print/cloud_print_connector.cc

Issue 1547593002: Introducing a net::GenerateMimeMultipartBoundary helper. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Self-review. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/policy/upload_job_impl.cc ('K') | « chrome/common/cloud_print/cloud_print_helpers.cc ('k') | chrome/service/cloud_print/printer_job_handler.cc » ('j') | google_apis/drive/base_requests.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/service/cloud_print/cloud_print_connector.cc

diff --git a/chrome/service/cloud_print/cloud_print_connector.cc b/chrome/service/cloud_print/cloud_print_connector.cc

index 0a7d7542e3976a8b20f23ac237adbe0366550579..bc6b6bcc529c906e43c6b3306dc0a8d53fb98d36 100644

--- a/chrome/service/cloud_print/cloud_print_connector.cc

+++ b/chrome/service/cloud_print/cloud_print_connector.cc

@@ -360,8 +360,7 @@ void CloudPrintConnector::ReportUserMessage(const std::string& message_id,

const std::string& failure_msg) {

// This is a fire and forget type of function.

// Result of this request will be ignored.

- std::string mime_boundary;

- CreateMimeBoundaryForUpload(&mime_boundary);

+ std::string mime_boundary = net::GenerateMimeMultipartBoundary();

GURL url = GetUrlForUserMessage(settings_.server_url(), message_id);

std::string post_data;

net::AddMultipartValueForUpload(kMessageTextValue, failure_msg, mime_boundary,

@@ -607,8 +606,7 @@ void CloudPrintConnector::OnReceivePrinterCaps(

const printing::PrinterBasicInfo& info = pending_tasks_.front().printer_info;

DCHECK(IsSamePrinter(info.printer_name, printer_name));

- std::string mime_boundary;

- CreateMimeBoundaryForUpload(&mime_boundary);

+ std::string mime_boundary = net::GenerateMimeMultipartBoundary();

std::string post_data;

net::AddMultipartValueForUpload(kProxyIdValue,