Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1517)

Unified Diff: net/base/mime_util_unittest.cc

Issue 1547593002: Introducing a net::GenerateMimeMultipartBoundary helper. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebasing... Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/base/mime_util_unittest.cc
diff --git a/net/base/mime_util_unittest.cc b/net/base/mime_util_unittest.cc
index 8bc61bc8052854e78f9795737bf8e2ad0f613007..0787d8cda505c2f5acb44fb86779f96a0547b987 100644
--- a/net/base/mime_util_unittest.cc
+++ b/net/base/mime_util_unittest.cc
@@ -273,6 +273,34 @@ TEST(MimeUtilTest, TestGetExtensionsForMimeType) {
}
}
+TEST(MimeUtilTest, TestGenerateMimeMultipartBoundary) {
+ std::string boundary1 = GenerateMimeMultipartBoundary();
+ std::string boundary2 = GenerateMimeMultipartBoundary();
+
+ // RFC 1341 says: the boundary parameter [...] consists of 1 to 70 characters.
+ EXPECT_GE(70u, boundary1.size());
+ EXPECT_GE(70u, boundary2.size());
+
+ // RFC 1341 asks to: exercise care to choose a unique boundary.
+ EXPECT_NE(boundary1, boundary2);
+ ASSERT_LE(16u, boundary1.size());
+ ASSERT_LE(16u, boundary2.size());
+
+ // Expect that we don't pick '\0' character from the array/string
+ // where we take the characters from.
+ EXPECT_EQ(std::string::npos, boundary1.find('\0'));
+ EXPECT_EQ(std::string::npos, boundary2.find('\0'));
+
+ // Asserts below are not RFC 1341 requirements, but are here
+ // to improve readability of generated MIME documents and to
+ // try to preserve some aspects of the old boundary generation code.
+ EXPECT_EQ("--", boundary1.substr(0, 2));
+ EXPECT_EQ("--", boundary2.substr(0, 2));
+ EXPECT_NE(std::string::npos, boundary1.find("MultipartBoundary"));
+ EXPECT_NE(std::string::npos, boundary2.find("MultipartBoundary"));
+ EXPECT_EQ("--", boundary1.substr(boundary1.size() - 2, 2));
+ EXPECT_EQ("--", boundary2.substr(boundary2.size() - 2, 2));
+}
TEST(MimeUtilTest, TestAddMultipartValueForUpload) {
const char ref_output[] =

Powered by Google App Engine
This is Rietveld 408576698