chrome/browser/chromeos/policy/upload_job_impl.h - Issue 1547593002: Introducing a net::GenerateMimeMultipartBoundary helper.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/policy/upload_job_impl.h

Issue 1547593002: Introducing a net::GenerateMimeMultipartBoundary helper. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebasing... Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/chromeos/policy/upload_job_impl.h

diff --git a/chrome/browser/chromeos/policy/upload_job_impl.h b/chrome/browser/chromeos/policy/upload_job_impl.h

index 958eef39c050b23f76ea6e8a7893234350d0919b..7c7106f25b4747cf461745a2d92be2c246289ebb 100644

--- a/chrome/browser/chromeos/policy/upload_job_impl.h

+++ b/chrome/browser/chromeos/policy/upload_job_impl.h

@@ -5,8 +5,6 @@

#ifndef CHROME_BROWSER_CHROMEOS_POLICY_UPLOAD_JOB_IMPL_H_

#define CHROME_BROWSER_CHROMEOS_POLICY_UPLOAD_JOB_IMPL_H_

-#include <stddef.h>

#include <map>

#include <string>

@@ -36,7 +34,7 @@ class UploadJobImpl : public UploadJob,

public:

virtual ~MimeBoundaryGenerator();

- virtual std::string GenerateBoundary(size_t length) const = 0;

+ virtual std::string GenerateBoundary() const = 0;

private:

DISALLOW_ASSIGN(MimeBoundaryGenerator);

@@ -48,8 +46,7 @@ class UploadJobImpl : public UploadJob,

public:

~RandomMimeBoundaryGenerator() override;

- std::string GenerateBoundary(

- size_t length) const override; // MimeBoundaryGenerator

+ std::string GenerateBoundary() const override; // MimeBoundaryGenerator

};

UploadJobImpl(const GURL& upload_url,

« no previous file with comments | « chrome/browser/chromeos/policy/upload_job.h ('k') | chrome/browser/chromeos/policy/upload_job_impl.cc » ('j') | net/base/mime_util.cc » ('J')