chrome/common/cloud_print/cloud_print_helpers.cc - Issue 1547593002: Introducing a net::GenerateMimeMultipartBoundary helper.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/cloud_print/cloud_print_helpers.cc

Issue 1547593002: Introducing a net::GenerateMimeMultipartBoundary helper. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebasing... Created 4 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/policy/upload_job_impl.cc ('K') | « chrome/common/cloud_print/cloud_print_helpers.h ('k') | chrome/service/cloud_print/cloud_print_connector.cc » ('j') | google_apis/drive/base_requests.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/cloud_print/cloud_print_helpers.cc

diff --git a/chrome/common/cloud_print/cloud_print_helpers.cc b/chrome/common/cloud_print/cloud_print_helpers.cc

index 406c54b33f2cc86ac1aea5c235806a5b329a39d4..03fba827f710179baf42b2d5190d9623596ce544 100644

--- a/chrome/common/cloud_print/cloud_print_helpers.cc

+++ b/chrome/common/cloud_print/cloud_print_helpers.cc

@@ -207,13 +207,6 @@ std::string GetMultipartMimeType(const std::string& mime_boundary) {

return std::string("multipart/form-data; boundary=") + mime_boundary;

}

-// Create a MIME boundary marker (27 '-' characters followed by 16 hex digits).

-void CreateMimeBoundaryForUpload(std::string* out) {

- int r1 = base::RandInt(0, std::numeric_limits<int32_t>::max());

- int r2 = base::RandInt(0, std::numeric_limits<int32_t>::max());

- base::SStringPrintf(out, "---------------------------%08X%08X", r1, r2);

std::string GetHashOfPrinterTags(const PrinterTags& printer_tags) {

return HashPrinterTags(PreparePrinterTags(printer_tags));

}