Introducing a net::GenerateMimeMultipartBoundary helper.

components/search_engines/template_url.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/search_engines/template_url.h"
 
 #include <string>
 #include <vector>
 
 #include "base/command_line.h"
 #include "base/format_macros.h"
 #include "base/i18n/icu_string_conversions.h"
 #include "base/i18n/rtl.h"
 #include "base/logging.h"
 #include "base/macros.h"
 #include "base/metrics/field_trial.h"
-#include "base/rand_util.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_piece.h"
 #include "base/strings/string_split.h"
 #include "base/strings/string_util.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "build/build_config.h"
 #include "components/google/core/browser/google_util.h"
 #include "components/metrics/proto/omnibox_input_type.pb.h"
 #include "components/search_engines/search_engines_switches.h"
@@ skipping 242 matching lines @@
 }
 
 bool TemplateURLRef::EncodeFormData(const PostParams& post_params,
                                     PostContent* post_content) const {
   if (post_params.empty())
     return true;
   if (!post_content)
     return false;
 
   const char kUploadDataMIMEType[] = "multipart/form-data; boundary=";
-  const char kMultipartBoundary[] = "----+*+----%016" PRIx64 "----+*+----";
   // Each name/value pair is stored in a body part which is preceded by a
-  // boundary delimiter line. Uses random number generator here to create
-  // a unique boundary delimiter for form data encoding.
-  std::string boundary = base::StringPrintf(kMultipartBoundary,
-                                            base::RandUint64());
+  // boundary delimiter line.
+  std::string boundary = net::GenerateMimeMultipartBoundary();
   // Sets the content MIME type.
   post_content->first = kUploadDataMIMEType;
   post_content->first += boundary;
   // Encodes the post parameters.
   std::string* post_data = &post_content->second;
   post_data->clear();
   for (const auto& param : post_params) {
     DCHECK(!param.name.empty());
     net::AddMultipartValueForUpload(param.name, param.value, boundary,
                                     param.content_type, post_data);
@@ skipping 1182 matching lines @@
       // patterns. This means that given patterns
       //    [ "http://foo/#q={searchTerms}", "http://foo/?q={searchTerms}" ],
       // calling ExtractSearchTermsFromURL() on "http://foo/?q=bar#q=' would
       // return false. This is important for at least Google, where such URLs
       // are invalid.
       return !search_terms->empty();
     }
   }
   return false;
 }