Introducing a net::GenerateMimeMultipartBoundary helper.

chrome/browser/chromeos/policy/upload_job_impl.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_POLICY_UPLOAD_JOB_IMPL_H_
 #define CHROME_BROWSER_CHROMEOS_POLICY_UPLOAD_JOB_IMPL_H_
 
 #include <stddef.h>

[bartfab (slow), 2016/01/05 14:20:45]

Nit: No longer used.

[Łukasz Anforowicz, 2016/01/05 19:16:49]

Done.

 
 #include <map>
 #include <string>
 
 #include "base/macros.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/scoped_vector.h"
 #include "chrome/browser/chromeos/policy/upload_job.h"
 #include "google_apis/gaia/oauth2_token_service.h"
@@ skipping 10 matching lines @@
 class UploadJobImpl : public UploadJob,
                       public OAuth2TokenService::Consumer,
                       public net::URLFetcherDelegate {
  public:
   // UploadJobImpl uses a MimeBoundaryGenerator to generate strings which
   // mark the boundaries between data segments.
   class MimeBoundaryGenerator {
    public:
     virtual ~MimeBoundaryGenerator();
 
-    virtual std::string GenerateBoundary(size_t length) const = 0;
+    virtual std::string GenerateBoundary() const = 0;
 
    private:
     DISALLOW_ASSIGN(MimeBoundaryGenerator);
   };
 
   // An implemenation of the MimeBoundaryGenerator which uses random
   // alpha-numeric characters to construct MIME boundaries.
   class RandomMimeBoundaryGenerator : public MimeBoundaryGenerator {
    public:
     ~RandomMimeBoundaryGenerator() override;
 
-    std::string GenerateBoundary(
-        size_t length) const override;  // MimeBoundaryGenerator
+    std::string GenerateBoundary() const override;  // MimeBoundaryGenerator
   };
 
   UploadJobImpl(const GURL& upload_url,
                 const std::string& account_id,
                 OAuth2TokenService* token_service,
                 scoped_refptr<net::URLRequestContextGetter> url_context_getter,
                 Delegate* delegate,
                 scoped_ptr<MimeBoundaryGenerator> boundary_generator);
   ~UploadJobImpl() override;
 
@@ skipping 86 matching lines @@
 
   // The data chunks to be uploaded.
   ScopedVector<DataSegment> data_segments_;
 
   DISALLOW_COPY_AND_ASSIGN(UploadJobImpl);
 };
 
 }  // namespace policy
 
 #endif  // CHROME_BROWSER_CHROMEOS_POLICY_UPLOAD_JOB_IMPL_H_