Record UMA for Physical Web settings fragment

Record UMA for Physical Web settings fragment

BUG=529962
Committed: https://crrev.com/6ccca5659c74bed2a307cde209f2579fc2554db9
Cr-Commit-Position: refs/heads/master@{#367116}

[cco3, 2015-12-22 02:03:09]

cco3@chromium.org changed reviewers:
+ newt@chromium.org

[cco3, 2015-12-22 02:03:51]

Description was changed from

==========
Record UMA for Physical Web settings fragment

BUG=529962
==========

to

==========
Record UMA for Physical Web settings fragment

BUG=529962
==========

[cco3, 2015-12-29 18:28:02]

cco3@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[gone, 2015-12-29 18:53:36]

lgtm, but would it make more sense to use histograms instead of actions?  You're
adding related pairs of actions that would probably be better off as a
histogram.

That said, you'll need one of the metrics folks to look at your actions.xml
change; I'm not an OWNER.

[cco3, 2015-12-29 18:55:19]

On 2015/12/29 18:53:36, dfalcantara wrote:
> lgtm, but would it make more sense to use histograms instead of actions? 
You're
> adding related pairs of actions that would probably be better off as a
> histogram.
> 
> That said, you'll need one of the metrics folks to look at your actions.xml
> change; I'm not an OWNER.

Yea, I wasn't sure.  I'll let a UMA tell me if I should change it.

[cco3, 2015-12-29 18:57:53]

cco3@chromium.org changed reviewers:
+ isherman@chromium.org

[Ilya Sherman, 2015-12-29 22:48:24]

On 2015/12/29 18:55:19, cco3 wrote:
> On 2015/12/29 18:53:36, dfalcantara wrote:
> > lgtm, but would it make more sense to use histograms instead of actions? 
> You're
> > adding related pairs of actions that would probably be better off as a
> > histogram.
> > 
> > That said, you'll need one of the metrics folks to look at your actions.xml
> > change; I'm not an OWNER.
> 
> Yea, I wasn't sure.  I'll let a UMA tell me if I should change it.

actions.xml lgtm.  In terms of whether to report actions or histograms, it's up
to you.  I tend to recommend enumerated histograms over actions because the
tooling is better for most types of analysis.  OTOH, if you're interested in
timestamp-based analysis, e.g. understanding sequences of user actions, then
reporting the metrics as actions might be better.  Please re-ping for review if
you switch over to histograms.

[cco3, 2015-12-29 22:51:11]

Thanks, I think I'll keep it like this then.

[cco3, 2015-12-29 22:51:15]

The CQ bit was checked by cco3@chromium.org

[commit-bot: I haz the power, 2015-12-29 22:51:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1547543003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1547543003/20001

[cco3, 2015-12-29 22:51:40]

Hi isherman@, could you take a look at this one too?

[cco3, 2015-12-29 22:56:45]

On 2015/12/29 22:51:40, cco3 wrote:
> Hi isherman@, could you take a look at this one too?


Sorry, ignore that comment.

[commit-bot: I haz the power, 2015-12-29 23:35:32]

Description was changed from

==========
Record UMA for Physical Web settings fragment

BUG=529962
==========

to

==========
Record UMA for Physical Web settings fragment

BUG=529962
==========

[commit-bot: I haz the power, 2015-12-29 23:35:33]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-29 23:36:36]

Description was changed from

==========
Record UMA for Physical Web settings fragment

BUG=529962
==========

to

==========
Record UMA for Physical Web settings fragment

BUG=529962

Committed: https://crrev.com/6ccca5659c74bed2a307cde209f2579fc2554db9
Cr-Commit-Position: refs/heads/master@{#367116}
==========

[commit-bot: I haz the power, 2015-12-29 23:36:37]

Patchset 2 (id:??) landed as
https://crrev.com/6ccca5659c74bed2a307cde209f2579fc2554db9
Cr-Commit-Position: refs/heads/master@{#367116}