remoting: use VerifyHostPinHash() in place on IsPinValid()

remoting/remoting_host_mac.gypi

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'variables': {
     'remoting_host_installer_mac_roots': [
       'host/installer/mac/',
       '<(DEPTH)/chrome/installer/mac/',
     ],
@@ skipping 159 matching lines @@
     {
       'target_name': 'remoting_host_prefpane',
       'type': 'loadable_module',
       'mac_bundle': 1,
       'product_extension': 'prefPane',
       'variables': {
         'bundle_id': '<!(python <(version_py_path) -f <(branding_path) -t "@MAC_PREFPANE_BUNDLE_ID@")',
         'host_bundle_name': '<!(python <(version_py_path) -f <(branding_path) -t "@MAC_HOST_BUNDLE_NAME@")',
         'prefpane_bundle_name': '<!(python <(version_py_path) -f <(branding_path) -t "@MAC_PREFPANE_BUNDLE_NAME@")',
       },
       'dependencies': [

[Sergey Ulanov, 2015/12/22 18:28:53]

I think you need to add other dependencies here. At very least remoting_base. It
will fail to compile without this.

[tfarina, 2015/12/23 15:32:00]

Done.

         'remoting_infoplist_strings',
       ],
       'defines': [
         'HOST_BUNDLE_NAME="<(host_bundle_name)"',
         'PREFPANE_BUNDLE_NAME="<(prefpane_bundle_name)"',
         'JSON_USE_EXCEPTION=0',
       ],
       'include_dirs': [
         '../third_party/jsoncpp/overrides/include/',
         '../third_party/jsoncpp/source/include/',
         '../third_party/jsoncpp/source/src/lib_json/',
       ],
 
       # These source files are included directly, instead of adding target

[Sergey Ulanov, 2015/12/22 18:28:53]

remove this comment

[tfarina, 2015/12/23 15:32:00]

Done.

       # dependencies, because the targets are not yet built for 64-bit on
       # Mac OS X - http://crbug.com/125116.
       #
       # TODO(lambroslambrou): Fix this when Chrome supports building for

[Sergey Ulanov, 2015/12/22 18:28:53]

remove TODO

[tfarina, 2015/12/23 15:32:00]

Done.

       # Mac OS X 64-bit - http://crbug.com/128122.
       'sources': [
         '../third_party/jsoncpp/overrides/src/lib_json/json_value.cpp',

[Sergey Ulanov, 2015/12/22 18:28:53]

add dependency on third_party/jsoncpp instead of compiling the files here.

[tfarina, 2015/12/23 15:32:00]

Done.

         '../third_party/jsoncpp/overrides/src/lib_json/json_reader.cpp',
         '../third_party/jsoncpp/source/src/lib_json/json_writer.cpp',
-        '../third_party/modp_b64/modp_b64.cc',
         'host/constants_mac.cc',
         'host/constants_mac.h',
         'host/host_config_constants.cc',

[Sergey Ulanov, 2015/12/22 18:28:53]

add dependency on remoting_host instead of compiling these files again.

[tfarina, 2015/12/23 15:32:00]

Done.

         'host/mac/me2me_preference_pane.h',
         'host/mac/me2me_preference_pane.mm',
         'host/mac/me2me_preference_pane_confirm_pin.h',
         'host/mac/me2me_preference_pane_confirm_pin.mm',
         'host/mac/me2me_preference_pane_disable.h',
         'host/mac/me2me_preference_pane_disable.mm',
       ],
       'link_settings': {
         'libraries': [
           '$(SDKROOT)/System/Library/Frameworks/Cocoa.framework',
@@ skipping 29 matching lines @@
           'variables': {
             # A real .dSYM is needed for dump_syms to operate on.
             'mac_real_dsym': 1,
           },
         }],  # 'mac_breakpad==1'
       ],  # conditions
     },  # end of target 'remoting_host_prefpane'
   ],  # end of 'targets'
 
 }