remoting: use VerifyHostPinHash() in place on IsPinValid()

remoting/remoting_host_mac.gypi

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'variables': {
     'remoting_host_installer_mac_roots': [
       'host/installer/mac/',
       '<(DEPTH)/chrome/installer/mac/',
     ],
@@ skipping 172 matching lines @@
       'defines': [
         'HOST_BUNDLE_NAME="<(host_bundle_name)"',
         'PREFPANE_BUNDLE_NAME="<(prefpane_bundle_name)"',
         'JSON_USE_EXCEPTION=0',
       ],
       'include_dirs': [
         '../third_party/jsoncpp/overrides/include/',
         '../third_party/jsoncpp/source/include/',
         '../third_party/jsoncpp/source/src/lib_json/',
       ],
-
-      # These source files are included directly, instead of adding target
-      # dependencies, because the targets are not yet built for 64-bit on
-      # Mac OS X - http://crbug.com/125116.
-      #
-      # TODO(lambroslambrou): Fix this when Chrome supports building for
-      # Mac OS X 64-bit - http://crbug.com/128122.
       'sources': [

[tfarina, 2015/12/24 20:50:43]

I don't understand what is going on with remoting_host_prefpane. Looks like it
wants to build i386 (32-bit) even when the host is x86_64 (64-bit).

Adding 'remoting_host' to dependencies list does not have any effect for:

$ ninja -C out/Release remoting_host_prefpane
...
Undefined symbols for architecture i386:
  "remoting::VerifyHostPinHash(std::__1::basic_string<char,
std::__1::char_traits<char>, std::__1::allocator<char> > const&,
std::__1::basic_string<char, std::__1::char_traits<char>,
std::__1::allocator<char> > const&, std::__1::basic_string<char,
std::__1::char_traits<char>, std::__1::allocator<char> > const&)", referenced
from:
      -[Me2MePreferencePane applyConfiguration:pin:] in
remoting_host_prefpane.me2me_preference_pane.i386.o

         '../third_party/jsoncpp/overrides/src/lib_json/json_value.cpp',
         '../third_party/jsoncpp/overrides/src/lib_json/json_reader.cpp',
         '../third_party/jsoncpp/source/src/lib_json/json_writer.cpp',
-        '../third_party/modp_b64/modp_b64.cc',
         'host/constants_mac.cc',
         'host/constants_mac.h',
         'host/host_config_constants.cc',
         'host/mac/me2me_preference_pane.h',
         'host/mac/me2me_preference_pane.mm',
         'host/mac/me2me_preference_pane_confirm_pin.h',
         'host/mac/me2me_preference_pane_confirm_pin.mm',
         'host/mac/me2me_preference_pane_disable.h',
         'host/mac/me2me_preference_pane_disable.mm',
       ],
       'link_settings': {
         'libraries': [
           '$(SDKROOT)/System/Library/Frameworks/Cocoa.framework',
           '$(SDKROOT)/System/Library/Frameworks/CoreFoundation.framework',
           '$(SDKROOT)/System/Library/Frameworks/PreferencePanes.framework',
           '$(SDKROOT)/System/Library/Frameworks/Security.framework',
         ],
       },
       'xcode_settings': {
         'ARCHS': ['i386', 'x86_64'],

[Sergey Ulanov, 2015/12/27 01:21:15]

Remove this line

[tfarina, 2015/12/27 21:22:30]

Thanks Sergey! After removing this, remoting_host_prefpane built for me.

         'GCC_ENABLE_OBJC_GC': 'supported',
         'INFOPLIST_FILE': 'host/mac/me2me_preference_pane-Info.plist',
         'INFOPLIST_PREPROCESS': 'YES',
         'INFOPLIST_PREPROCESSOR_DEFINITIONS': 'VERSION_FULL="<(version_full)" VERSION_SHORT="<(version_short)" BUNDLE_ID="<(bundle_id)"',
       },
       'mac_bundle_resources': [
         'host/mac/me2me_preference_pane.xib',
         'host/mac/me2me_preference_pane_confirm_pin.xib',
         'host/mac/me2me_preference_pane_disable.xib',
         'host/mac/me2me_preference_pane-Info.plist',
@@ skipping 12 matching lines @@
           'variables': {
             # A real .dSYM is needed for dump_syms to operate on.
             'mac_real_dsym': 1,
           },
         }],  # 'mac_breakpad==1'
       ],  # conditions
     },  # end of target 'remoting_host_prefpane'
   ],  # end of 'targets'
 
 }