Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1547483003: fix hair fuzz (Closed)

Created:
5 years ago by caryclark
Modified:
5 years ago
Reviewers:
msarett, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

fix hair fuzz If the end and control points of a quad, conic, or cubic are the same, adjust all of them when stretching the curve to account for a square or round end cap. If all of the points are the same, move all but the last. Enlarge the clip check to account for the cap. The clip bug was detected by ASAN. R=reed@google.com, msarett@google.com BUG=571214 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1547483003 Committed: https://skia.googlesource.com/skia/+/40b7d3b48b522e233ee63d2c88cff82c4bd5fb15

Patch Set 1 #

Patch Set 2 : handle case where all points are equal #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -6 lines) Patch
M gm/strokes.cpp View 1 chunk +32 lines, -0 lines 0 comments Download
M src/core/SkScan_Hairline.cpp View 1 3 chunks +14 lines, -6 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
caryclark
5 years ago (2015-12-21 21:00:53 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1547483003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1547483003/1
5 years ago (2015-12-21 21:00:59 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-21 21:16:58 UTC) #6
caryclark
5 years ago (2015-12-22 13:44:51 UTC) #9
msarett
lgtm
5 years ago (2015-12-22 13:57:01 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1547483003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1547483003/20001
5 years ago (2015-12-22 13:58:03 UTC) #12
commit-bot: I haz the power
5 years ago (2015-12-22 14:13:37 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/40b7d3b48b522e233ee63d2c88cff82c4bd5fb15

Powered by Google App Engine
This is Rietveld 408576698